Better error message for missing let #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BookOfGreg
reviewed
Sep 18, 2021
I've run into this problem a number of times. The original error message is actually a `NoMethodError` and it's not always immediately clear what the solution is, particuarly if you're new to rspec or rswag Wanted to see if this kind of behavior is something that the rswag team would be interested in adopting. I have a few other of these in mind (will do as small PRs, with tests)
jaydorsey
force-pushed
the
jay/better_error_message
branch
from
e1f8e2d
to
3263806
Compare
|
@BookOfGreg I updated with both fo your suggestions, and fixed the failing specs by doing a rebase/update. Let me know if you want any additional changes |
inverse
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into this a number of times, and helped developers triage this
as well. This is meant to improve the developer experience by providing
an improved error message when we forget to configure a let
The original error message is actually a
NoMethodError/undefined methodand it's not always immediately clear what the solution is, particularly if
you're new to rspec/rswag
Here's an example error (the real one that prompted me to create this PR)
And the new error message:
I have a number of other small changes like this that I can contribute as well
if these types of pull requests are welcome.