Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Style/SingleArgumentDig rubocop issues in swagger_formatter #486

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Fix Style/SingleArgumentDig rubocop issues in swagger_formatter #486

merged 2 commits into from
Sep 12, 2022

Conversation

rnestler
Copy link
Contributor

@rnestler rnestler commented Feb 4, 2022 •
edited

jtannas
jtannas reviewed Sep 10, 2022
View reviewed changes
Copy link
Collaborator

@jtannas jtannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnestler Thanks for the PR & sorry for the long wait in getting it reviewed.

Would you mind rebasing it off of the current master and adding an accompanying note to the changelog? Thanks 🙇‍♂️

@rnestler
Copy link
Contributor Author

Would you mind rebasing it off of the current master and adding an accompanying note to the changelog? Thanks bowing_man

@jtannas Done. Personally I wouldn't add a changelog entry for such simple style changes which don't change behavior

@rnestler
Copy link
Contributor Author

@jtannas I needed to rebase again, since there was an issue in the code (Had an instance of parameters instead of :parameters. Maybe it happened during the first rebase? I'm not sure since there weren't any conflicts)

@jtannas jtannas merged commit 16deca0 into rswag:master Sep 12, 2022
@rnestler rnestler deleted the fix-rubocup-issue branch September 12, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtannas jtannas Awaiting requested review from jtannas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnestler @jtannas