Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue and PR template updates #496

Merged
merged 6 commits into from
Feb 13, 2022
Merged

Conversation

sergioisidoro
Copy link
Member

@sergioisidoro sergioisidoro commented Feb 13, 2022

  • While triaging the issues, documentation is quite often missing in Pull requests, so added a bullet a checkbox for updating docs
  • Also it's unclear what version people are targeting with the older versions. This might not be a problem in the future, but it's nice to ask for the contributors to have backwards compatibility in mind
  • Added headers and metadata in the templates
  • Added a config so Github will display a issue template chooser
  • Moved pull request template out of the folder, because right now we only have on pull request template

@sergioisidoro sergioisidoro changed the title Add links to OAS specs and compatibility list to PR template Issue and PR template updates Feb 13, 2022
@@ -0,0 +1 @@
blank_issues_enabled: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I assume this is what we were missing for the issue picker.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think just the existence of the file will trigger the picker, but since we're here, let's also not allow blank issues :)

@BookOfGreg BookOfGreg merged commit d03910a into master Feb 13, 2022
@BookOfGreg BookOfGreg deleted the sergioisiodoro-pr-template branch February 13, 2022 11:46
@sergioisidoro
Copy link
Member Author

Wohoo! :)

Screenshot 2022-02-13 at 15 09 53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants