Fix examples, and upgrade examples to OAS3 #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BookOfGreg
approved these changes
Feb 25, 2022
|
Sorry for the long delay on this. I made some final checks, and since this was already approved, I went ahead and clicked the merge button :) |
This was referenced Apr 28, 2022
|
@sergioisidoro sorry to bug you but is this feature being held until version 3.0? Or should we expect another 2.x release with some of these recent changes? |
3 tasks
romanblanco
added a commit
to romanblanco/compliance-backend
that referenced
this pull request
Sep 23, 2022
rswag/rswag#501 bundle update rswag-specs bundle update rswag-api bundle update rswag-ui
romanblanco
added a commit
to romanblanco/compliance-backend
that referenced
this pull request
Sep 26, 2022
Fix for response examples [1] has been recently released
in version rswag 2.6.0 [2]
The commit is updating rswag packages to the latest
version:
$ bundle update rswag-specs
$ bundle update rswag-api
$ bundle update rswag-ui
[1] rswag/rswag#501
[2] https://github.com/rswag/rswag/releases/tag/2.6.0
romanblanco
added a commit
to romanblanco/compliance-backend
that referenced
this pull request
Sep 26, 2022
Fix for response examples [1] has been recently released
in version rswag 2.6.0 [2]
The commit is updating rswag packages to the latest
version:
$ bundle update rswag-specs
$ bundle update rswag-api
$ bundle update rswag-ui
[1] rswag/rswag#501
[2] https://github.com/rswag/rswag/releases/tag/2.6.0
romanblanco
added a commit
to RedHatInsights/compliance-backend
that referenced
this pull request
Sep 26, 2022
Fix for response examples [1] has been recently released
in version rswag 2.6.0 [2]
The commit is updating rswag packages to the latest
version:
$ bundle update rswag-specs
$ bundle update rswag-api
$ bundle update rswag-ui
[1] rswag/rswag#501
[2] https://github.com/rswag/rswag/releases/tag/2.6.0
Closed
|
@dollerbill, this was released already, removing Gem 3.0.0 milestone. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Started at #500 but took a bit more idealistic approach here into turning the
metadataobject already as close as possible to the OAS3 specification. As mentioned in #500, themetadataobject is diverging quite a lot from the OAS specification, so this is already an attempt at bringing it back to as close to the final swagger document as possible.Moves examples into the new OAS3 example specification
This concerns this parts of the Open API Specification:
The changes I made are compatible with:
Related Issues
Links to any related issues.
Checklist