Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update json-schema dependency version constraint #517

Merged
merged 2 commits into from
Sep 11, 2022

Conversation

mustardnoise
Copy link
Contributor

@mustardnoise mustardnoise commented May 9, 2022

Problem

json-schema dependency used in rswag-specs is outdated. This prevents already existing json-schema dependency in a project from being updated.

Solution

Update json-schema version constraint

@Tossmann
Copy link

Great stuff!

@fpietka
Copy link

fpietka commented Sep 9, 2022

Going back to a 2014 version is indeed a problem for project already using this gem.
Is there any issue that can be discussed with this PR to help this move forward? 🙏

@jtannas
Copy link
Collaborator

jtannas commented Sep 10, 2022

@mustardnoise heyo - sorry for the long wait.
We've since updated our test system and gotten new maintainers on board to start catching up.

Would you mind rebasing this PR off of the latest master so that we can see the results of the new test suite runs on it?
Other than that, a quick note in the changelog would be helpful 🙇‍♂️

@mustardnoise
Copy link
Contributor Author

mustardnoise commented Sep 11, 2022

hi @jtannas. I've rebased the branch and updated the CHANGELOG

@jtannas jtannas merged commit 8a7b6aa into rswag:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants