Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme response header for open api 3.0 #518

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

YaEvan
Copy link
Contributor

@YaEvan YaEvan commented May 12, 2022

Problem

OAS3 defines the response header needs to specify the schema, if you follow the example in the README, there will be a syntax error

Solution

Update README.md

This concerns this parts of the Open API Specification:

The changes I made are compatible with:

  • OAS2
  • OAS3
  • OAS3.1

Related Issues

Links to any related issues.

Checklist

  • Added tests
  • Changelog updated
  • Added documentation to README.md

Copy link
Collaborator

@jtannas jtannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BookOfGreg just a correction to the README

Both the orginal version and the new one in the PR function, but this update puts it in line with the Swagger Docs.
https://swagger.io/docs/specification/describing-parameters/#header-parameters

@jtannas jtannas merged commit d7b20be into rswag:master Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants