add deprecation notices for EOL Ruby & RSpec #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtannas
force-pushed
the
deprecate-EOL-versions
branch
from
80d958c
to
4fbad12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage reports in #551 show that our biggest gaps are for RSpec2 specific methods.
The last RSpec 2.X release was back in 2014-06-01 and Ruby2.6 EOL happened on March 31 2022.
The easiest solution is to just drop support for the old versions.
Dropping support for them is technically a breaking change, so I've added deprecation notices when those versions are detected.
We should probably drop support for Rails 5 as well since it's EOL, but I haven't found how to detect the Rails version yet 馃