Allow Host header setting #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbroadbent
reviewed
Jul 18, 2023
| # Host header | ||
| host = metadata[:operation][:host] || swagger_doc[:host] | ||
| if host.present? | ||
| host = example.respond_to?(:'Host') ? example.send(:'Host') : host |
There was a problem hiding this comment.
@jtannas I was wondering if you might have meant: example.respond_to?(:'host') ? example.send(:'host') here? (lower case h.) My tests broke after this change, where RSpec started trying to use my live production API host instead of the test host. example.host returns the correct test value for me, but I don't have a example.Host method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing option to set
Hostheader.Closes: #184.
Solution
There already is reviewed solution in #184.
This PR only adds test coverage to help the changes get merged.
This concerns this parts of the Open API Specification:
The changes I made are compatible with:
Related Issues
Checklist
Steps to Test or Reproduce
...