Fix RequestFactory gsub for base_path_from_servers #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridar
reviewed
Mar 14, 2023
This was referenced Mar 14, 2023
Commit 2264b03 introduced a change to this method where the gsub replacement of the server url switched from the global Regexp match variable of \$1 to the block argument for gsub. This change made it so that the argument to the variable name lookup include the braces used in the string for the url variable. That lead to the hash not returing any matching keys and values and the generated URI string of '://' being passed to the URI() method which raise an error.
Co-authored-by: Julien Girard <julien09girard@gmail.com>
romanblanco
reviewed
Mar 17, 2023
There was a problem hiding this comment.
@saturnflyer Thank you for fixing it!
Please, just update the CHANGELOG.md with the PR number and document the change in README.md examples. Than it's good to be merged 👍
|
A change in test-app would also be nice for demonstration. |
Co-authored-by: Roman Blanco <1187051+romanblanco@users.noreply.github.com>
romanblanco
approved these changes
Mar 18, 2023
romanblanco
approved these changes
Mar 18, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Commit 2264b03 introduced a change to this method where the gsub replacement of the server url switched from the global Regexp match variable of $1 to the block argument for gsub.
This change made it so that the argument to the variable name lookup include the braces used in the string for the url variable.
That lead to the hash not returing any matching keys and values and the generated URI string of '://' being passed to the URI() method which raise an error.
Solution
The solution is to
useuse the global Regextrto replace matching{and}characters from the block argument passed togsub!$1match variable inRswag::Specs::RequestFactory#base_path_from_serversThis concerns this parts of the Open API Specification:
protocolThe changes I made are compatible with:
Related Issues
None
Checklist
Steps to Test or Reproduce
The configuration in the spec was updated to include a
protocolvalue in the server variables with a:defaultkey. Only this change is necessary to trigger an Invalid URI error.