parameter[:getter] option #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NastyaPatutina
approved these changes
Mar 7, 2023
TruesSpeak
approved these changes
Mar 7, 2023
|
Hello @jtannas, can you please look at this PR? Maybe this is still worked solution for rswag? |
romanblanco
reviewed
Mar 19, 2023
|
Thanks for response, i will fix all issues within days! |
pechorin
force-pushed
the
parameter-getter
branch
from
20fc48b
to
795d5e6
Compare
|
@romanblanco thanks for cool review, can you check my fixes please? :) |
romanblanco
approved these changes
Mar 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adopted pull request #436
Fix known issue: conflict with rspec default matchers include #188 (and also with status method)
Solution
Add support for :getter parameter option to explicitly define custom param getter method and avoid rspec conflicts with include matcher and status method
This concerns this parts of the OpenAPI Specification:
The changes I made are compatible with:
Related Issues
#188
Checklist
Steps to Test or Reproduce