Fix path expansion #660
Merged
Fix path expansion #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts part of efd4ea4 The dir_string is ignored if file_name starts with a slash. In our case of retrieving the HTTP request path from env, path will start with a slash. This broke swagger file resolution.
This was referenced Jul 13, 2023
romanblanco
approved these changes
Jul 13, 2023
|
Damn. We should add a regression test, because all tests passed :/ Sorry for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts part of efd4ea4
Problem
The dir_string is ignored if file_name starts with a slash. In our case of retrieving the HTTP request path from env, path will start with a slash. This broke swagger file resolution.
Solution
Revert back to the
File.joinmethod which is safer in case of risk of additional slashes.This concerns this parts of the OpenAPI Specification:
The changes I made are compatible with:
Related Issues
#654 (comment)
#653
Checklist
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.