-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to support Rails 7.1 #677
Conversation
While this PR don't get merged, a temporary solution is to declare the fork in Gemfile: github "xvega/rswag", branch: "update-rails-dependency" do
gem "rswag-api"
gem "rswag-ui"
gem "rswag-specs"
end |
Is swagger UI showing up for you? I'm in the process of updating but rswag-ui won't load up. Will need to investigate further but would be interesting to hear from you. |
@gobijan +1. rswag-ui not works after this upgrade. |
As temporary solution with rswag-ui before new version will be released: You need to serve swagger-ui-bundle files (js, css) from public/api-docs folder. You can copy manually those files from gem install folder. Seems like gem has additional build phase for release build. |
Probably should also add 7.1 to the workflow for CI : https://github.com/rswag/rswag/blob/master/.github/workflows/ruby.yml#L15 (and maybe time to drop EOL rubies)... EDIT: this PR actually starts cleaning up CI config https://github.com/rswag/rswag/pull/625/files |
Anything we can do to help move this along? |
This update works (locally and with the workaround from above) it's also similar to a previous PR #450 so I guess we're just waiting for approval and a new release. |
Thanks for emailing me, I was not aware of this and likely wouldn't have been for a couple more weeks yet. |
Deployed, let me know if there's any issues from this. Thanks again! |
Problem
Rails 7.1 has been officially released, I'm updating my project from Rails 7.0 to 7.1 but I found some dependency issues.
Solution
Updating dependencies for railties and actionpack
This concerns this parts of the OpenAPI Specification:
The changes I made are compatible with:
Related Issues
#676
Checklist
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.