Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package-lint target #134

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Add package-lint target #134

merged 1 commit into from
Jun 14, 2022

Conversation

matsl
Copy link
Collaborator

@matsl matsl commented Dec 13, 2021

What

This is a setup to run package-lint on Hyperbole.

Why

I wanted to see what challenges we have if we would like to make Hyperbole package-lint clean. Provided here to share it and show the setup. Including example of running it.

Not intended to be merged at this point.

@matsl matsl marked this pull request as ready for review December 13, 2021 21:33
@matsl
Copy link
Collaborator Author

matsl commented Dec 13, 2021

Run this command
> make package-lint 2>&1 | grep -v \"hyperbole\" | tee package-lint.txt
Grep it for removing all errors complaining about functions not having the package prefix "hyperbole". Around 2034 lines that is. 😄
The rest goes into the file below:
package-lint.txt

@matsl matsl added the WIP Work In Progress label Dec 13, 2021
@rswgnu
Copy link
Owner

rswgnu commented Dec 13, 2021 via email

@matsl
Copy link
Collaborator Author

matsl commented Dec 14, 2021

For this check the major difference we have is that we don't have a package unique prefix for all our files and functions. hypb comes first to my mind in that respect. Would be a major undertake to fix that of course. Maybe also points in the direction of having multiple packages like, hypb for the hyperbole core, hypb-kotl for kotl-mode and possibly others depending on how you would want to slice and dice it. Anyway - think about it.

@rswgnu
Copy link
Owner

rswgnu commented Dec 14, 2021 via email

@matsl matsl force-pushed the experiment-with-package-lint branch from d9baef1 to d151ff8 Compare June 14, 2022 16:52
@matsl
Copy link
Collaborator Author

matsl commented Jun 14, 2022

This is a new run of package-lint with filtered out all the warning|errors about files and functions not having the proper prefix and that should not be used to separate prefix from rest of function|variables|symbols.

That is above 3000 lines of error messages. What remains are:
package-lint-2.txt

Some of these looks like easy fixes. I might attempt to fix some of them.

@matsl matsl removed the WIP Work In Progress label Jun 14, 2022
@rswgnu
Copy link
Owner

rswgnu commented Jun 14, 2022 via email

@matsl
Copy link
Collaborator Author

matsl commented Jun 14, 2022

*.org is not a known type. Trying with pdf!?
output.pdf

@matsl matsl merged commit bf2bd2e into master Jun 14, 2022
@matsl matsl deleted the experiment-with-package-lint branch June 14, 2022 19:14
@rswgnu
Copy link
Owner

rswgnu commented Jun 14, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants