-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some package lint messages #199
Conversation
Warning is related to running under 24.2 or older, which we do not support, so only cosmetics!?
See "(elisp)Coding conventions"
ChangeLog
Outdated
|
||
* hibtypes.el (cl-lib): Require cl-lib to remove package-lint warning. | ||
|
||
* hyperbole.el: Remove defalias for compatilility with obsolete functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compatibility misspelling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
ChangeLog
Outdated
* hyperbole.el: Remove defalias for compatilility with obsolete functions | ||
since Emacs 25.1 and outline-flag-region available since 2003. | ||
|
||
* hui-em-but.el (hproperty:good-colors): package-lint code formating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must start with having the spell checker active in the commit window. 🙏
What
Fix some package lint messages.
Why
Some or the reaming issues looked small so I gave it a try.
Some are really hard, impossible!?, to fix since we change function in other packages. I supposed that would require some help from the packages we modify to support some hooks or similar for those changes to be possible cleanly!?
Note
Each type of change is in a separate commit except for the ChangeLog and copyright year update that tend to be afterthoughts in my case and comes together as the last commit.