Rename global var to remove shadowing warnings #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsl
force-pushed
the
remove_free_var_label-sep-len_warnings
branch
from
2eb1f30
to
107f56b
Compare
matsl
force-pushed
the
remove_free_var_label-sep-len_warnings
branch
from
107f56b
to
952b6f2
Compare
|
Let's talk about this one tomorrow. I think it should be resolved the opposite way with the function parameters renamed and the global staying the same since that is the one that people might set by name in their own Lisp files. |
|
For the discussion marked |
rswgnu
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rename global var to remove shadowing warnings.
Why
By renaming the global variable to
kview-label-sep-lenthe functionality is kept intact. The shadowing warnings are by this removed. It remains to analyze if there is any code that relies on dynamic binding.Note that this PR should not make the situation worse or even change. It just makes it clear where the global variable is used. With lexical scoping the value passed in to functions will not affect functions using the global variable.