Doc strings within 80 char limit for hib-kbd.el #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswgnu
requested changes
Jul 21, 2022
hib-kbd.el
Outdated
| @@ -447,12 +458,13 @@ For an approximate inverse of this, see `key-description'." | |||
| res))) | |||
|
|
|||
| (defun kbd-key:extended-command-p (key-series) | |||
| "Return non-nil if the string KEY-SERIES is a normalized extended command invocation, i.e. M-x command." | |||
| "Return non-nil if the KEY-SERIES is a normalized extended command invocation. | |||
| A command of the form M-x command." | |||
There was a problem hiding this comment.
FYI: checkdocs complains: Keycode` M-x embedded in doc string. Use \\<mapvar> & \\[command] instead
Not sure how to apply that so keeping the suggested text for now. Will not cause a warning when byte compiling.
matsl
force-pushed
the
long_doc_strings_hib-kbd_el
branch
from
767017b
to
55fc350
Compare
rswgnu
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Doc strings within 80 char limit for hib-kbd.el
Why
Extracted from longer PR for easier review.