Cleanup - Remove unused function and do not use removed function #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswgnu
requested changes
Jul 27, 2022
matsl
force-pushed
the
do_not_use_obsolete_functions
branch
from
922f6f4
to
98ea2c7
Compare
matsl
commented
Aug 2, 2022
matsl
commented
Aug 2, 2022
matsl
force-pushed
the
do_not_use_obsolete_functions
branch
from
98ea2c7
to
0991333
Compare
matsl
changed the title
|
@rswgnu I learned today how easy it is to remove a file from a PR and then it was easy to repurpose this PR to just a small cleanup. PTAL. |
|
Let's work on the merge of this when we are together as well. |
matsl
force-pushed
the
do_not_use_obsolete_functions
branch
from
36fd5db
to
e10ae65
Compare
|
@rswgnu With the fix of the CI this PR now builds so can be merged if approved. Was that the reason for merging this together? It has 9 commits but all boils down to two small changes. Replace of one function and removal of another. So just look at the combined result and not each commit. I'll squash so the commits becomes one. |
rswgnu
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Do not use obsolete functions.
Why
We can use the new function directly since they are supported from 27.2.
Note
Also fixes a duplication related to an obsolete function. Maybe I missed this or made a bad rebase!?