Interactive hyperbole demo #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I figured it'd be better to create a PR for each document so it's easier to review and get merged in? If not, I can add them all into this PR. |
|
Hi Hank:This is great news.Separate PRs are better as longer ones can take me a long time to process.Happy new year. I look forward to checking these out.-- BobOn Dec 31, 2022, at 12:42 AM, Hank Greenburg ***@***.***> wrote:
Also, I figured it'd be better to create a PR for each document so it's easier to review and get merged in? If not, I can add them all into this PR.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
matsl
reviewed
Dec 31, 2022
matsl
reviewed
Dec 31, 2022
matsl
reviewed
Dec 31, 2022
matsl
reviewed
Dec 31, 2022
matsl
reviewed
Dec 31, 2022
matsl
reviewed
Dec 31, 2022
matsl
reviewed
Dec 31, 2022
Co-authored-by: Mats Lidell <mats.lidell@lidells.se>
|
I added in the recommended changes! |
|
Just a gentle ping here. |
|
@rswgnu I've been crazy busy the last couple months with finishing grad school and moving across the country, but now I finally have more time to wrap all the tutorials up. So out of curiosity, what am I missing from this to get it merged? No rush, of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hank here, we communicated over the summer via email about my work on these documents.
Sorry this has taken forever, I am finally on a break from grad school. Here though is the interactive hyperbole demo I have been working on. I figured we didn't want to replace the current demos with these interactive ones I've been working on, so I made a new directory for them. I also have a hyrolo one that I am virtually done with and a koutliner one that is very close to being done.
I am very open to suggestions on changing names or anything like that!