Cleanup patch, use old functions #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswgnu
approved these changes
Feb 5, 2023
From Stefan Monnier. Thanks.
matsl
force-pushed
the
cleanup_patch_from_stefan
branch
from
b796d66
to
5a8f391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cleanup patch, use old functions. From Stefan Monnier. Thanks.
Why
Cleanup is a good thing. I picked out this cleanup from the patch #118 originating from Stefan. I suggest we close that PR now since it is only the
hbut--inhibit-somethingrefactoring that is left in that. It will still be available in closed state so we will not loos it in case we forget why it was once created.