Make kotl-autoloads without building hyperbole-autoloads.el #307
Conversation
Makefile
Outdated
| @@ -426,7 +427,7 @@ hyperbole-autoloads.el: $(EL_COMPILE) | |||
| $(EMACS_BATCH) --debug --eval "(progn (setq generated-autoload-file (expand-file-name \"hyperbole-autoloads.el\") backup-inhibited t) (let (find-file-hooks) (hload-path--make-directory-autoloads \".\" generated-autoload-file)))" | |||
|
|
|||
| kotl/kotl-autoloads.el: $(EL_KOTL) | |||
| $(EMACS_BATCH) --debug --eval "(progn (setq generated-autoload-file (expand-file-name \"kotl/kotl-autoloads.el\") backup-inhibited t) (let (find-file-hooks) (hload-path--make-directory-autoloads \"kotl/\" generated-autoload-file)))" | |||
| $(EMACS_PLAIN_BATCH) --debug --eval "(progn (setq generated-autoload-file (expand-file-name \"kotl/kotl-autoloads.el\") backup-inhibited t) (let (find-file-hooks) (make-directory-autoloads \"kotl/\" generated-autoload-file)))" | |||
There was a problem hiding this comment.
This breaks versions of Emacs that I have tested in the past that lack make-directory autoloads. I will have to see if it is true of 27.1. If not, then we can use it.
There was a problem hiding this comment.
Oh, you are right. That can be true. The interesting part is that the scraping for autoloads works for all our versions we use here but I don't think it uses that target. We don't build for 21.1 though. Only 27.2. I'll add a test to check.
There was a problem hiding this comment.
The test proves it breaks on 27.2. I'll see if I can fix a workaround.
There was a problem hiding this comment.
@rswgnu The autoload generation for kotl now fallbacks to Emacs 27 functionality if not the more modern functions are available.
The hyperbole-autoloads target also generates the kotl-autoloads which is wrong. This is a test to see if the proposed change works on all versions of Emacs. It flips the order and by that runs the kotl autoloads generation first.
matsl
force-pushed
the
make_kotl_autoloads_without_triggering_other_builds
branch
from
5fca7ea
to
069cf2a
Compare
matsl
force-pushed
the
make_kotl_autoloads_without_triggering_other_builds
branch
from
069cf2a
to
510b171
Compare
matsl
deleted the
make_kotl_autoloads_without_triggering_other_builds
branch
What
Make
kotl/kotl-autoloadswithout buildinghyperbole-autoloads.elWhy
The target
kotl/kotl-autoloads.elhas as a side effect to also build thehyperbole-autoloads.el.That is not correct and can lead to unexpected problems and even errors. Patch by Stefan Monnier. This PR fixed this so that onlykotl-autoloadsare produced as a result of that make target.