Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence various byte compiler warnings #320

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

matsl
Copy link
Collaborator

@matsl matsl commented Apr 23, 2023

What

Fix a mix of different types of byte compiler warnings.

Why

Taking yet another stab at getting the warnings down to a low number.

@matsl matsl requested a review from rswgnu April 23, 2023 20:46
hbdata.el Outdated Show resolved Hide resolved
hui-mouse.el Show resolved Hide resolved
hycontrol.el Show resolved Hide resolved
@rswgnu
Copy link
Owner

rswgnu commented Apr 24, 2023

Looks good, otherwise.

@matsl matsl requested a review from rswgnu April 24, 2023 22:00
@matsl matsl force-pushed the fix_mix_of_byte_compiler_warnings branch from 3245599 to db4b0a5 Compare April 25, 2023 22:17
@matsl
Copy link
Collaborator Author

matsl commented Apr 26, 2023

@rswgnu Thanks. Sorry for being bureaucratic but can you for clarity also approve the PR (using the button) since it is now marked as "Changes requested"?

@rswgnu rswgnu removed their request for review April 27, 2023 00:24
@rswgnu
Copy link
Owner

rswgnu commented Apr 27, 2023

It won't let me. Just merge.

@matsl
Copy link
Collaborator Author

matsl commented Apr 27, 2023 via email

@matsl matsl merged commit 944e763 into master Apr 27, 2023
4 checks passed
@matsl matsl deleted the fix_mix_of_byte_compiler_warnings branch April 27, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants