Rework sed command to avoid the trailing quotation mark #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswgnu
requested changes
Jun 22, 2023
matsl
force-pushed
the
use_make_pattern_for_load-file_command
branch
from
b277afd
to
8051f63
Compare
matsl
changed the title
rswgnu
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Retake - Rework sed command to avoid the trailing quotation mark.
Why
This reworks the sed command slightly so that the trailing quotation mark is not needed anymore. That was the ultimate goal of the previous version since that quote looks strange and messes up the editor (as it seems.)
The change in fact removes all uses of quotes in the load commands. They does not seem to be needed as we don't have spaces in the file names.