Verify url is called #344
Merged
Verify url is called #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that url checks are performed. Add test for regression for urls given in double quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Verify url is called. Ensures that url checks are performed. Add test for regression for urls given in double quotes.
Why
I noticed a regression for urls given in quotes. They get identified as
ibtypes::annot-bib. My ibuts for browser links in my HYPB file stopped working a few days ago or so.So this PR will not build because of the regression.
I also noticed that these tests did not properly identify when the expected url was not called at all. Added a check for that in a simple manner for now using a global variable. Will think about how we can improve that further.
See test