Stefan scratch hyperbole 20230621 without questions #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* hload-path.el (hyperb:dir): Don't use it as fallback because it's too hackish and too rarely useful.
Scanning the stack frame can be useful in some unusual cases, but should be avoided when a straightforward let-binding does the trick. * hmouse-drv.el (hkey--within-help): New var. (hkey-help): Bind it. * hibtypes.el (pathname): Consult it. (hibtypes--within-org-link-outside-org-mode): New var. (org-link-outside-org-mode): Use it to detect recursion. * hui-mouse.el (hyp--within-smart-org): New var. (smart-org): Bind it. (hkey-alist): Consult it. (-flatten): Move declaration to where we know the function is actually available.
* hmouse-drv.el (hui--ignore-action-key-depress-prev-point): New var. * hui.el (hui:ebut-create, hui:ebut-edit, hui:ebut-edit-region) (hui:gbut-create, hui:gbut-edit, hui:link-create, hui:ibut-create) (hui:ibut-edit): Bind it. * hbut.el (ebut:program, ibut:program): Bind it. (ebut:operate, ibut:operate): Use it instead of `hyperb:stack-frame`. * hversion.el (hyperb:stack-frame): Delete function.
* test/kcell-tests.el (kcell): Don't presume `kotl/` is in `load-path`.
* kotl/kview.el (kview:first-invisible-point): Use `kview:char-invisible-p`. (kview:char-visible-p): Delete function.
(hyperbole-mode): Remove redundant keywords.
* hversion.el (hyperb:mouse-buttons): * hload-path.el (hyperb:microsoft-os-p, hyperb:wsl-os-p): Don't needlessly predefine internal variables. (load-path): Don't add `test` to the `load-path`.
Copying this whole keymap definition to `hyperbole-autoloads.el` just slows down startup unnecessarily.
(hui-select-initialize): Use `dolist`; let-bind vars rather than just `setq`ing them; use closures. (hui-select-goto-matching-tag): Fix markup. (hui-select-indent-non-end-regexp-alist) (hui-select-indent-end-regexp-alist): Use conventional markup for metavars.
* hactypes.el (annot-bib): Avoid gratuitous `setq`. (man-show): Declare `Man-notify-method` to fix miscompilation. (rfc-toc): `select-buffer` doesn't exist.
* Makefile (LOAD_EL): Escape trailing double quote so it's not confused with a beginning-of-string. * hbut.el: Require `house-drv` to fix miscompilation of let-bindings of `hui--ignore-action-key-depress-prev-point`. Prefer #' to quote function names. (hbut:max-len, ibut:label-start, ibut:label-end): Add `defvar`s to fix some of the many warnings and to make sure they're compiled as dynvars. (ibut:at-type-p): Remove unused `types` var. (defib): Remove redundant indent property. * hibtypes.el (org-link-outside-org-mode): Silence some warnings. (grep-msg): Avoid NUL bytes in source files (makes Emacs thinks they're binary). * set.el: Prefer #' to quote function names.
This file suffers from a large number of warnings, some of them correspond to real bugs. This patch does *not* fix them. Remove redundant `:group` args. Remove obsolete `*` in `defcustom` docstrings. (hyrolo--initialize-file-list): New function extracted (and simplified) from `hyrolo-initialize-file-list`. (hyrolo-file-list): Use it. (hyrolo-initialize-file-list): Use it as well. Declare it as obsolete. (hyrolo-yank-reformat-function): Give it a non-nil default value. (hyrolo-yank): Blindly call it now that it can't be nil.
(hyperb:window-sys-term): Simplify since (string-match "[-_]" term) always returns nil here. (hyperb:automount-prefixes): Remove unused var. (id-info-item): Remove unused backslash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Stefan scratch hyperbole 20230621 without changes where we have questions.
Why
This is PR #343 with the issues that we don't understand removed. This is so we can easier push this. Issues pointed out in pure FIXME comments are still kept, as they are suggestions for improvements and will not change functionality.