Remove redundant :group args and obsolete * in defcustom docstrings #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsl
force-pushed
the
remove-group-lines
branch
from
456c15e
to
bb80f6b
Compare
rswgnu
requested changes
Jul 1, 2023
|
Ok, great.-- BobOn Jul 1, 2023, at 5:36 PM, Mats Lidell ***@***.***> wrote:
@matsl commented on this pull request.
In hyrolo.el:
Default is American style. See documentation of the function
`format-time-string' for format options."
- :type 'string
- :group 'hyperbole-rolo)
I think the defgroup hyperbole-rolo creates the grouping that you want. hyperbole-rolo is a group that is a subgroup of hyperbole. hyperbole-rolo is then default for all the defcustom.
This is how the custom settings look after the change. (Byte compiled the branch and restarted Emacs. That would be enough to see the new settings I think.)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
rswgnu
approved these changes
Jul 2, 2023
Contribution from Stefan Monnier. Thanks Stefan.
|
All the other places, the :type line was left in (or added back in the
diff). Here it just seems to be deleted.
…On Sun, Jul 2, 2023 at 4:08 AM Mats Lidell ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In hyrolo.el
<#353 (comment)>:
> Default is American style. See documentation of the function
`format-time-string' for format options."
- :type 'string
I don't understand the comment. The :type line kept!?
—
Reply to this email directly, view it on GitHub
<#353 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5WPD24V7AH5IGFCSRPFODXOET6TANCNFSM6AAAAAAZZCKFTE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
OK. I have merged the PR now. I'll make a note of that and take a look later. |
|
Later is now. I went to the master branch and it looks like it is still there. Line 77 in ac6e50e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
:groupargs are redundant and*is obsolete indefcustomdocstrings.Contribution from Stefan Monnier. Thanks Stefan.
See: https://github.com/rswgnu/hyperbole/pull/343/files#r1244628372
cc: @monnier