-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let git see el-files #383
Let git see el-files #383
Conversation
@rswgnu If you have emacs lisp files in the hyperbole folder that you want git to ignore you can have a user local gitignore for those. That way it will only affect your environment. |
You can use the hypb:rgrep command (which can be configured to use ripgrep)
to search over all the Hyperbole .el files. If invoked within a .el
buffer, it will automatically filter to search just .el files.
Do you really need anything else. Stop using grep within a shell for
Hyperbole and you will find your life will get a bit easier.
Bob
…On Tue, Sep 26, 2023 at 5:44 PM Mats Lidell ***@***.***> wrote:
What
Do not ignore el-files.
Why
- Emacs lisp files are the core of the package so most likely what we
want git to track.
- Tools that respect gitignore also fails to look at Emacs lips files.
An example of that is ripgrep which makes the setting extra tedious to
work with since all searches fail to find things in Emacs lisp files unless
explicitly told to look there.
- (Possibly and oversight or error that this change was committed!?)
------------------------------
You can view, comment on, or merge this pull request online at:
#383
Commit Summary
- d08e869
<d08e869>
Let git see el-files
File Changes
(1 file <https://github.com/rswgnu/hyperbole/pull/383/files>)
- *M* .gitignore
<https://github.com/rswgnu/hyperbole/pull/383/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947>
(1)
Patch Links:
- https://github.com/rswgnu/hyperbole/pull/383.patch
- https://github.com/rswgnu/hyperbole/pull/383.diff
—
Reply to this email directly, view it on GitHub
<#383>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5WPD5B7SRXJGH7CMX5UHLX4NECPANCNFSM6AAAAAA5IMAH4Y>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
😄 @rswgnu I like how your are thinking... BUT It is not only about me. Everyone else that uses the repo will get the, IMHO, strange behavior that el-files are ignored in an Emacs lisp project and it will affect all other tools that respect the .gitignore configuration as a hint that these are uninteresting files. That will be both Emacs tools and external tools. Please reconsider to make this into your personal setting instead to not affect general users. That can either be done by using a local setting for the Hyperbole repo, as shown in the link, or in your general .gitiignore in your home folder. |
Ok, will work on it as well as temporarily reverting using org-mode in the demos, so the tests will pass and we can merge to master.-- BobOn Oct 2, 2023, at 8:54 AM, Mats Lidell ***@***.***> wrote:
Do you really need anything else
😄
@rswgnu I like how your are thinking... BUT It is not only about me. Everyone else that uses the repo will get the, IMHO, strange behavior that el-files are ignored in an Emacs lisp project and it will affect all other tools that respect the .gitignore configuration as a hint that these are uninteresting files. That will be both Emacs tools and external tools.
Please reconsider to make this into your personal setting instead to not affect general users. That can either be done by using a local setting for the Hyperbole repo, as shown in the link, or in your general .gitiignore in your home folder.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I have done all this and merged into master. You can now merge your
.gitignore PR and then fork off master to work on cleaning up your PR that
removes all the byte-compile errors.
Thanks.
…On Mon, Oct 2, 2023 at 3:57 AM Robert Weiner ***@***.***> wrote:
Ok, will work on it as well as temporarily reverting using org-mode in the
demos, so the tests will pass and we can merge to master.
-- Bob
On Oct 2, 2023, at 8:54 AM, Mats Lidell ***@***.***> wrote:
Do you really need anything else
😄
@rswgnu <https://github.com/rswgnu> I like how your are thinking... BUT
It is not only about me. Everyone else that uses the repo will get the,
IMHO, strange behavior that el-files are ignored in an Emacs lisp project
and it will affect all other tools that respect the .gitignore
configuration as a hint that these are uninteresting files. That will be
both Emacs tools and external tools.
Please reconsider to make this into your personal setting instead to not
affect general users. That can either be done by using a local setting for
the Hyperbole repo, as shown in the link, or in your general .gitiignore in
your home folder.
—
Reply to this email directly, view it on GitHub
<#383 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5WPDZMXVOTJRPIO3OUCNLX5JXJ5ANCNFSM6AAAAAA5IMAH4Y>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
d08e869
to
a929d0b
Compare
What
Do not ignore el-files.
Why
ripgrep
which makes the setting extra tedious to work with since all searches fail to find things in Emacs lisp files unless explicitly told to look there.