Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let git see el-files #383

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Let git see el-files #383

merged 1 commit into from
Oct 2, 2023

Conversation

matsl
Copy link
Collaborator

@matsl matsl commented Sep 26, 2023

What

Do not ignore el-files.

Why

  • Emacs lisp files are the core of the package so most likely what we want git to track.
  • Tools that respect gitignore also fails to look at Emacs lips files. An example of that is ripgrep which makes the setting extra tedious to work with since all searches fail to find things in Emacs lisp files unless explicitly told to look there.
  • (Possibly and oversight or error that this change was committed!?)

@matsl matsl requested a review from rswgnu September 26, 2023 21:46
@matsl
Copy link
Collaborator Author

matsl commented Oct 1, 2023

@rswgnu If you have emacs lisp files in the hyperbole folder that you want git to ignore you can have a user local gitignore for those. That way it will only affect your environment.

@rswgnu
Copy link
Owner

rswgnu commented Oct 2, 2023 via email

@matsl
Copy link
Collaborator Author

matsl commented Oct 2, 2023

Do you really need anything else

😄

@rswgnu I like how your are thinking... BUT It is not only about me. Everyone else that uses the repo will get the, IMHO, strange behavior that el-files are ignored in an Emacs lisp project and it will affect all other tools that respect the .gitignore configuration as a hint that these are uninteresting files. That will be both Emacs tools and external tools.

Please reconsider to make this into your personal setting instead to not affect general users. That can either be done by using a local setting for the Hyperbole repo, as shown in the link, or in your general .gitiignore in your home folder.

@rswgnu
Copy link
Owner

rswgnu commented Oct 2, 2023 via email

@rswgnu
Copy link
Owner

rswgnu commented Oct 2, 2023 via email

@matsl matsl merged commit 7350bdb into master Oct 2, 2023
5 checks passed
@matsl matsl deleted the do-not-ignore-el-files branch October 2, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants