Add kotl prefix to kview buffer local variable #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsl
commented
Oct 4, 2023
| * kotl/kview.el (kotl-kview): Add kotl prefix to kview and use | ||
| defvar-local. | ||
|
|
||
| * General removal of warnings by using defvar and declare-function for |
There was a problem hiding this comment.
Added this to cover for the lack of ChangeLog comments in the previous PR.
rswgnu
approved these changes
Oct 5, 2023
|
Approved. Give it a good run through, changing the viewspec of two different koutlines side by side to ensure the view local changes work, then save, kill and reload and see if viewspec restores separately for both.Cheers,-- BobOn Oct 4, 2023, at 6:57 PM, Mats Lidell ***@***.***> wrote:
@matsl requested your review on: #389 Add kotl prefix to kview buffer local variable.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add kotl prefix to kview buffer local variable.
Why
Removes warnings for kview lacking a prefix. Makes code easier to read since parameters exists with the same name. Warnings for that are also avoided by this change.