Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defcustom type for hui-mini menus #391

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

matsl
Copy link
Collaborator

@matsl matsl commented Oct 7, 2023

What

Update defcustom type for hui-mini menus so that customize works. Extra bonus removes warnings about not valid type.

Why

I noted the following warnings for the master build.

hui-mini.el:941:12: Warning: in defcustom for `hui:menu-rolo': `nil' is not a valid type
hui-mini.el:971:12: Warning: in defcustom for `hui:menu-to': `nil' is not a valid type
hui-mini.el:1010:12: Warning: in defcustom for `hui:doc-a-z': `nil' is not a valid type

That led me to try to use the defcustom for these menues and they were broken. I have verified with 27.2 that the defcustom works as expected after this change.

Q: Do we want to have these menus customizable? (Using customize for long and complicated expressions feels to me like a bad interface. Would you as a user not prefer to define the menu a lisp expression!?)

Note

Different warnings from native run and docker run

Interesting thing is that we are getting a few warnings when we build using the docker images that I don't see when building natively on my machine. I do not get these. I have no idea why. Is it because I run a local emacs that has native compilation!? When I run in docker locally I get the same warnings as in CI/CD which is expected.

hui:doc-a-z

This menu is a little complicated since it also have items that does not have an sexp. See the the last "" selection. From the editing perspective it seems like setting the sexp to nil works and the default value is displayed properly. So this menu might benefit from another type definition.

@matsl matsl requested a review from rswgnu October 7, 2023 08:54
@matsl matsl merged commit 5f0a642 into master Oct 7, 2023
5 checks passed
@matsl matsl deleted the fix-hui-mini-defcustom-menues branch October 7, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants