Update defcustom type for hui-mini menus #391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update defcustom type for hui-mini menus so that customize works. Extra bonus removes warnings about not valid type.
Why
I noted the following warnings for the master build.
That led me to try to use the defcustom for these menues and they were broken. I have verified with 27.2 that the defcustom works as expected after this change.
Q: Do we want to have these menus customizable? (Using customize for long and complicated expressions feels to me like a bad interface. Would you as a user not prefer to define the menu a lisp expression!?)
Note
Different warnings from native run and docker run
Interesting thing is that we are getting a few warnings when we build using the docker images that I don't see when building natively on my machine. I do not get these. I have no idea why. Is it because I run a local emacs that has native compilation!? When I run in docker locally I get the same warnings as in CI/CD which is expected.
hui:doc-a-z
This menu is a little complicated since it also have items that does not have an sexp. See the the last "" selection. From the editing perspective it seems like setting the sexp to nil works and the default value is displayed properly. So this menu might benefit from another type definition.