Matsl rsw add missing fast demo tests #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsl
commented
Dec 28, 2023
| @@ -135,11 +135,11 @@ | |||
|
|
|||
| ** Pathname Implicit Buttons | |||
|
|
|||
| "HY-NEWS#ORG MODE:2:6" - outline section anchor & relative line number | |||
| "HY-NEWS#ORG MODE:3:6" - outline section anchor & relative line number | |||
There was a problem hiding this comment.
The link to line 2 leads to an empty line which leaves the column info unused. Hence the update to bring pos to a line with text.
matsl
commented
Dec 28, 2023
| @@ -240,13 +240,6 @@ | |||
| (action-key) | |||
| (hy-test-helpers:should-last-message "Result = nil; Boolean value = False"))) | |||
|
|
|||
| (ert-deftest demo-implicit-button-action-button-variable-display-test () | |||
There was a problem hiding this comment.
This is duplicate so I removed it in favor of having it in the fast-demo section.
rswgnu
approved these changes
Dec 29, 2023
|
Fantastic, I approve. -- Bob
…On Thu, Dec 28, 2023 at 11:49 PM Mats Lidell ***@***.***> wrote:
@matsl <https://github.com/matsl> requested your review on: #426
<#426> Matsl rsw add missing fast
demo tests.
—
Reply to this email directly, view it on GitHub
<#426 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5WPDYXWKV75XTDINRZKWTYLYAOZAVCNFSM6AAAAABBGAFJ4OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGM2TIMRRGM2DONY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Matsl rsw add missing fast demo tests. (That was remaining at the time.)
Note
This ends this days work. Will be busy most of tomorrow so will pick it up again probably first tomorrow evening.
There are a few tests that could need some improvement but they are hopefully an improvement and much closer to the examples in the FAST-DEMO file.