Add tests for non file ebut creation and deletion #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Matsl rsw add tests for various ebut in non-file buffers and non-file buffers in message-mode.
Why
More tests are good and we have a TODO-item around this.
Note
See
ebut-delete-removes-ebut-in-non-file-buffer. It looks likehui:ebut-unmarktries to get the corresponding file of the buffer which does not exists. Oddly the message-mode test works but might be due to the special tests around mail buffers. I haven't debugged it that deep yet. The test is marked as expected failed.Also removed a test case that was almost identical with a variation.