Remove tar-ball dependency on elc files #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The el-files are now compiled under pkg_hyperbole as part of the tar-ball creation.
rswgnu
approved these changes
Jan 15, 2024
|
Removed the byte compilation step so that elc will not be part of the tar-ball. |
rswgnu
approved these changes
Jan 15, 2024
matsl
deleted the
matsl-rsw-do-not-byte-compile-before-extracting-to-tmp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove tar-ball dependency on elc files.
The el-files are now compiled under pkg_hyperbole as part of the tar-ball creation.Why
There was a dependency that caused the elc-file to be required before the pkg_hyperbole build step.
That caused make to compile them to early.This PR removes that dependencyand builds the elc-files as part of creating the tar-ball in the pkg_hyperbole folder.