Remove skip guard on test that works in batch mode #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove skip guard on test that works in batch mode.
Why
Try to run as many tests as possible in batch mode.
Note 1
It seems most tests that has the guard for not running them in batch mode actually requires that. I only found one test.
I have not tested to run all with skip guards in batch mode. Instead I have tested a few and if they failed to run I have looked for calling patterns in related test cases. If they use the same setup I have concluded that they probably not will work in batch mode either.
Note 2
I have some good thing to mention now though. While working on the presentation I found a hack that we might be able to use to run the interactive tests in the CI/CD. It passes my first limited test anyway. It is on my todo to play more with that. I think it is post 9.0 release though. We can run the interactive tests locally using docker if we want to sanity check before the release.