Add single file match tests for some hyrolo hide and show commands #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes helper method for turning a buffer with invisible regions into a plain string with the ellipses indicating where the invisible portions for the file are.
rswgnu
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add single file match tests for some hyrolo hide and show commands.
Includes helper method for turning a buffer with invisible regions into a plain string with the ellipses indicating where the invisible portions for the file are.
Why
Hyrolo needs a lot of testing.
Note
These tests are designed to succeed, Whether the HyRolo buffer looks right is another issue and will require a review.
Maybe not helpful in this respect the matching string is written as a one line string for making the size of the test cases smaller. Maybe it would make sense for these types of tests, with visual impact, to write the matching string out as a multi line string in the code. What do you think?
There are likely more tests cases around these functions like having matches in multiple files and multiple file types etc but will add those separately and as we feel are required.