-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dead "NEW React UI" link #290
Comments
The server.py should launch the Node.js process on 3000. I think it's the
port that's not exposed. Maybe there's something more missing.
…On Sun, Mar 17, 2024, 11:49 PM Alan Fregtman ***@***.***> wrote:
The line:
https://github.com/rsxdalv/tts-generation-webui/blob/c1013de6a03cdf0898c577ce0b579be5ad18bf40/server.py#L62
...adds a "NEW React UI" markdown link in the header that goes to
localhost:3000 but there seems to be nothing set up to actually run
anything on this port.
Is the docker-compose.yml missing something?
—
Reply to this email directly, view it on GitHub
<#290>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTRXIYKKKHC7YSY666RWVDYYYFUXAVCNFSM6AAAAABE2RBHB6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4TAOBYGEZTQOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Hmm, when launching the Docker image ( I guess that's it; npm is missing. Also missing is a line to expose port 3000 in the docker-compose.yml:
|
Thanks, I will fix it. |
* add install disclaimer * upgrade vocos to 0.1.0 * readme * add vall-e * add turkish model to bark voice clone * add React UI to Dockerfiles #290 * fix * readme
I pushed the update. Please test the new image and let me know how it goes. https://github.com/rsxdalv/tts-generation-webui/actions/runs/8393137834/job/22987441352 |
Seems to work now as far as serving a UI on port 3000 is concerned, but FYI the link assumes it is running as localhost, which may not always be so. In my case I run this container on a beefy remote machine and so clicking the "NEW React UI" takes me to... nothing... but swapping the port number does work. Linking to a different port number relatively is not allowed in HTML, but with a bit of JS you can take your link:
and use JS to swap the port number on hover:
Works like a charm and displays the actual real link on hover, like a natural link. |
That's amazing, thank you, I have included it in the latest commit. Thankfully gradio's markdown accepts HTML. |
The line:
tts-generation-webui/server.py
Line 62 in c1013de
...adds a "NEW React UI" markdown link in the header that goes to localhost:3000 but there seems to be nothing set up to actually run anything on this port.
Is the docker-compose.yml missing something?
The text was updated successfully, but these errors were encountered: