Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify and add test for metaframe loader; add inits for codecov. #18

Merged
merged 4 commits into from
Jun 15, 2020

Conversation

rsyi
Copy link
Owner

@rsyi rsyi commented Jun 15, 2020

Addresses the following issues:

#8
#9
#10

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #18 into master will increase coverage by 49.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #18       +/-   ##
===========================================
+ Coverage    0.00%   49.72%   +49.72%     
===========================================
  Files          15       15               
  Lines         549      549               
===========================================
+ Hits            0      273      +273     
+ Misses        549      276      -273     
Impacted Files Coverage Δ
metaframe/loader/metaframe_loader.py 92.85% <ø> (+92.85%) ⬆️
metaframe/utils/neo4j.py 11.11% <0.00%> (+11.11%) ⬆️
metaframe/models/connection_config.py 16.66% <0.00%> (+16.66%) ⬆️
...ame/extractor/amundsen_neo4j_metadata_extractor.py 18.18% <0.00%> (+18.18%) ⬆️
metaframe/engine/presto_engine.py 32.47% <0.00%> (+32.47%) ⬆️
metaframe/utils/extractor_wrappers.py 34.61% <0.00%> (+34.61%) ⬆️
metaframe/models/presto_watermark.py 47.05% <0.00%> (+47.05%) ⬆️
metaframe/utils/connections.py 50.00% <0.00%> (+50.00%) ⬆️
metaframe/engine/sql_alchemy_engine.py 62.85% <0.00%> (+62.85%) ⬆️
metaframe/engine/base_engine.py 75.00% <0.00%> (+75.00%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4b867...ad76cdb. Read the comment docs.

@rsyi rsyi merged commit cf77260 into master Jun 15, 2020
@rsyi rsyi deleted the rsyi/add-metaframe-loader-test branch June 24, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants