v1.1.2+ does not process last line if it misses the terminating LF #135
Labels
Comments
rgerhards
added a commit
to rgerhards/liblognorm
that referenced
this issue
Aug 24, 2015
This problem occurs with the very last line of a rulebase (at EOF). If it is not properly terminated (LF missing), it is silently ignored. Previous versions did obviously process lines in this case. While technically this is invalid input, we can't outrule that such rulebases exist. For example, they do in the rsyslog testbench, which made us aware of the problem (see rsyslog/rsyslog#489 ). I think the proper way of addressing this is to process such lines without termination, as many other tools do as well. closes rsyslog#135
rgerhards
added a commit
to rgerhards/liblognorm
that referenced
this issue
Aug 24, 2015
This problem occurs with the very last line of a rulebase (at EOF). If it is not properly terminated (LF missing), it is silently ignored. Previous versions did obviously process lines in this case. While technically this is invalid input, we can't outrule that such rulebases exist. For example, they do in the rsyslog testbench, which made us aware of the problem (see rsyslog/rsyslog#489 ). I think the proper way of addressing this is to process such lines without termination, as many other tools do as well. closes rsyslog#135
rgerhards
added a commit
to rgerhards/liblognorm
that referenced
this issue
Aug 24, 2015
This problem occurs with the very last line of a rulebase (at EOF). If it is not properly terminated (LF missing), it is silently ignored. Previous versions did obviously process lines in this case. While technically this is invalid input, we can't outrule that such rulebases exist. For example, they do in the rsyslog testbench, which made us aware of the problem (see rsyslog/rsyslog#489 ). I think the proper way of addressing this is to process such lines without termination, as many other tools do as well. closes rsyslog#135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This problem occurs with the very last line of a rulebase (at EOF). If it is not properly terminated (LF missing), it is silently ignored. Previous versions did obviously process lines in this case. While technically this is invalid input, we can't outrule that such rulebases exist. For example, they do in the rsyslog testbench, which made us aware of the problem (see rsyslog/rsyslog#489).
I think the proper way of addressing this is to process such lines without termination, as many other tools do as well. Maybe we should emit a warning, but not sure if that makes a lot of sense (especially as this case is pretty uncommon and not a real issue).
The text was updated successfully, but these errors were encountered: