Fix FD leak when socket shutdown is one-sided #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@okulev we are facing a similar issue but with nginx instead of AWS LB.. has this changed worked well for you? I don't quite understand the reasoning behind the change you made, but we are considering trying it. Hoping for an official fix soon. |
|
@okulev we need a rebase to solve the merge conflict. Will you do that? Else I can handle it. |
AWS LB has timeouts when connection is inactive and when this happens, AWS LB shuts down socket from one-side only. When rsyslog detects one-sided shutdown, it assumes that connection is closed while it isn't. The connection is left unclosed and unclosed FD are piling up, eventually filling up FD number space. Removing the assignment to -1 allows rsyslog to close the connection later.
|
@okulev FYI: I have done the merge and force-pushed |
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 75.69% 75.69%
=======================================
Files 21 21
Lines 4102 4102
=======================================
Hits 3105 3105
Misses 997 997
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS LB has timeouts when connection is inactive and when this happens, AWS LB shuts down socket from one-side only. When rsyslog detects one-sided shutdown, it assumes that connection is closed while it isn't. The connection is left unclosed and unclosed FD are piling up, eventually filling up FD number space.
Removing the assignment to -1 allows rsyslog to close the connection later.