Add global() parameters for legacy parser config statements #15
Comments
|
Started down this path, wanted you to check over the first one I tackled before I went through the rest I realize that commit removes the old style configuration directive, not sure if you would like it to stick around or not. If it should stick around, would moving it to glbl.c make more sense? |
|
Looks great! The current set of old style directives need to stick. That's a rsyslog policy: never break compatibility without a hard need. I suggest that you also move the old-style definitions over to glbl.c (if it is already supported there, at least). We should just not add any more old style directives. |
curl use SIGALRM to timeout handling. but it doesn't work in linux threads and the signal is delivered to an *arbitary* threads which almost guarantees crashing if a wrong thread picks up the signal. ``` (gdb) bt #0 0x00007f8b8859aa6d in addbyter () from libcurl.so.4 rsyslog#1 0x00007f8b8859b993 in dprintf_formatf () from libcurl.so.4 rsyslog#2 0x00007f8b8859bfd5 in curl_mvsnprintf () from libcurl.so.4 rsyslog#3 0x00007f8b8859ac42 in curl_msnprintf () from libcurl.so.4 rsyslog#4 0x00007f8b8858bbf6 in Curl_failf () from libcurl.so.4 rsyslog#5 0x00007f8b885826ef in Curl_resolv_timeout () from libcurl.so.4 rsyslog#6 0x00007f8b88cf2dfd in clock_gettime () from /lib64/libc.so.6 rsyslog#7 0x00007f8b6c01b1e0 in ?? () rsyslog#8 0x00007f8b887d58e8 in Curl_crealloc () from libcurl.so.4 rsyslog#9 0x00007f8b6c01a5a0 in ?? () rsyslog#10 0x00007f8b887d58e8 in Curl_crealloc () from libcurl.so.4 rsyslog#11 0x00007f8b6c002860 in ?? () rsyslog#12 0x000000000000000a in ?? () rsyslog#13 0x00007f8b6c01b5b0 in ?? () rsyslog#14 0x00007f8b6c0028c0 in ?? () rsyslog#15 0x00007f8b6c00c630 in ?? () rsyslog#16 0x000000000000000a in ?? () rsyslog#17 0x00007f8b6c0028c0 in ?? () rsyslog#18 0x0000000000000018 in ?? () rsyslog#19 0x00007f8b885a5432 in Curl_llist_remove () from libcurl.so.4 rsyslog#20 0x0000000004000000 in ?? () rsyslog#21 <signal handler called> rsyslog#22 0x0000006e0000005b in ?? () Cannot access memory at address 0x0 ``` References * https://curl.haxx.se/libcurl/c/threadsafe.html * https://curl.haxx.se/libcurl/c/CURLOPT_NOSIGNAL.html * https://www.redhat.com/archives/libvir-list/2012-October/msg00008.html
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Currently, there is no equivalent for runtime/parser.c legacy config statements. This is especially bad as we do not want to add additional config statements in legacy style.
The current set of legacy statements should be added to runtime/glbl.c parameters, which are configured via the global() statement. As parser.c only manipulates global variables, it should be sufficient to access the same variables from glbl.c as well. It's probably a bit tricky here to guard against setting parameters via legacy style and global(), but we may accept this weakness for a while. Parser parameters should begin with "parser." inside the global name space.
The text was updated successfully, but these errors were encountered: