Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove liblogging-stdlog dependency #2706

Open
rgerhards opened this issue May 14, 2018 · 2 comments
Open

remove liblogging-stdlog dependency #2706

rgerhards opened this issue May 14, 2018 · 2 comments

Comments

@rgerhards
Copy link
Member

Liblogging-stdlog was introduced to provide a broader ability to send rsyslog internal logs to different sources. However, most distros did not pick up that capability and so instead we do a regular syslog() call. We assume that the actual functionality is never used in practice, so we plan to retire it. That makes building rsyslog from source easier.

#2705 disabled the use of liblogging-stdlog by default during configure. So users (and distros!) could still opt-in to have it enabled if they desire.

With this issue, a couple of releases later, we want to completely remove the functionality.

If you have a strong reason why you still need it, please post here. If by the assigned milestone we will not see complaints with good reasoning here, we will remove the code.
@rgerhards rgerhards added this to the v8.39 milestone May 14, 2018
@rgerhards rgerhards changed the title remove libloggin-stdlog dependency remove liblogging-stdlog dependency May 14, 2018
@rgerhards rgerhards mentioned this issue May 14, 2018
Closed
rgerhards added a commit to rgerhards/rsyslog that referenced this issue May 14, 2018
@rgerhards
build system: do not use liblogging-stdlog dependency by default
0091c7d 
Liblogging-stdlog was introduced to provide a broader ability to send rsyslog
internal logs to different sources. However, most distros did not pick up
that capability and so instead we do a regular syslog() call. We assume that
the actual functionality is never used in practice, so we plan to retire it.
That makes building rsyslog from source easier.

The plan is to disable use of liblogging-stdlog by default during
configure. So users (and distros!) can still opt-in to have it enabled if
they desire.

A couple of releases later, we want to completely remove the functionality,
except if there has desire been shown in the meantime which justifies to keep
liblogging-stdlog.

This patch is for disabling liblogging-stdlog by default. We now also
emit a warning message ("liblogging-stdlog will go away") so that users
know what is going on and my react.

closes rsyslog#2705
see also rsyslog#2706
@rgerhards rgerhards mentioned this issue May 14, 2018
Merged
@rgerhards rgerhards self-assigned this Oct 26, 2018
@rgerhards rgerhards modified the milestones: v8.39, v8.40 Oct 29, 2018
@rgerhards rgerhards added do_first Things that should be done very soon,usually used for things that did not make it into prev release. and removed do_first Things that should be done very soon,usually used for things that did not make it into prev release. labels Oct 29, 2018
@rgerhards
Copy link
Member Author

This was just done in May 2018 8.36. So it is a bit early to remove it right now. I guess I picked the wrong label when I opened the issues.

@rgerhards rgerhards modified the milestones: v8.40, v8.42 Oct 29, 2018
@rgerhards
Copy link
Member Author

We must note that the testbench also uses this functionality, so there is need for some actual code changes.

@rgerhards rgerhards modified the milestones: v8.42, v8.47 Oct 30, 2018
@rgerhards rgerhards mentioned this issue Jan 22, 2019
Merged
@rgerhards rgerhards removed their assignment Apr 26, 2019
@rgerhards rgerhards modified the milestones: v8.1910, v8.1911 Oct 1, 2019
@rgerhards rgerhards modified the milestones: v8.1911, v8.2001 Nov 8, 2019
@rgerhards rgerhards modified the milestones: v8.2001, v8.2002 Jan 12, 2020
@rgerhards rgerhards modified the milestones: v8.2002, v8.2004 Feb 26, 2020
@rgerhards rgerhards removed this from the v8.2004 milestone Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rgerhards