Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sndrcv_relp_tls-cfgcmd.sh test failed #4131

Closed
Whissi opened this issue Jan 18, 2020 · 10 comments · Fixed by #4263
Closed

sndrcv_relp_tls-cfgcmd.sh test failed #4131

Whissi opened this issue Jan 18, 2020 · 10 comments · Fixed by #4263
Assignees
Labels
Milestone

Comments

@Whissi
Copy link
Contributor

Whissi commented Jan 18, 2020

Test sndrcv_relp_tls-cfgcmd.sh failed in rsyslog-8.2001.0 with librelp-1.5.0:

testbench: TZ env var not set, setting it to UTC
------------------------------------------------------------
09:46:57[0]  Test: ./sndrcv_relp_tls-cfgcmd.sh
------------------------------------------------------------
config rstb_309614_999fa94f_.conf is:
     1	module(load="../plugins/imdiag/.libs/imdiag")
     2	global(inputs.timeout.shutdown="60000"
     3	       default.action.queue.timeoutshutdown="20000"
     4	       default.action.queue.timeoutEnqueue="20000")
     5	# use legacy-style for the following settings so that we can override if needed
     6	$MainmsgQueueTimeoutEnqueue 20000
     7	$MainmsgQueueTimeoutShutdown 10000
     8	$IMDiagListenPortFileName rstb_309614_999fa94f.imdiag.port
     9	$IMDiagServerRun 0
    10	$IMDiagAbortTimeout 580
    11	
    12	:syslogtag, contains, "rsyslogd"  ./rstb_309614_999fa94f.started
    13	###### end of testbench instrumentation part, test conf follows:
    14	
    15	module(	load="../plugins/imrelp/.libs/imrelp" 
    16		tls.tlslib="openssl")
    17	# then SENDER sends to this port (not tcpflood!)
    18	input(	type="imrelp" port="35529" tls="on"
    19		tls.tlscfgcmd="Protocol=ALL,-SSLv2,-SSLv3,-TLSv1,-TLSv1.2" 
    20		)
    21	
    22	$template outfmt,"%msg:F,58:2%\n"
    23	:msg, contains, "msgnum:" action(type="omfile" file="rstb_309614_999fa94f.out.log" template="outfmt")
rsyslogd: NOTE: RSYSLOG_DEBUG_TIMEOUTS_TO_STDERR activated
rsyslogd 8.2001.0 error: invalid debug option 'nologfuncflow' - ignored
rsyslogd 8.2001.0 error: invalid debug option 'noprintmutexaction' - ignored
main Q:Reg: worker start requested, num workers currently 0
main Q:Reg: wrkr start initiated with state 0, num workers now 1
rsyslog debug: main Q:Reg: worker 0x7ff1c7c43a40 started
rsyslog debug: main Q:Reg: started with state 3, num workers now 1
09:46:57[0]  rstb_309614_999fa94f:.pid found, pid 39945
09:46:57[0]  rsyslogd startup msg seen, pid  39945
waiting for file rstb_309614_999fa94f.imdiag.port
imdiag port: 36613
config rstb_309614_999fa94f_2.conf is:
     1	module(load="../plugins/imdiag/.libs/imdiag")
     2	global(inputs.timeout.shutdown="60000"
     3	       default.action.queue.timeoutshutdown="20000"
     4	       default.action.queue.timeoutEnqueue="20000")
     5	# use legacy-style for the following settings so that we can override if needed
     6	$MainmsgQueueTimeoutEnqueue 20000
     7	$MainmsgQueueTimeoutShutdown 10000
     8	$IMDiagListenPortFileName rstb_309614_999fa94f.imdiag2.port
     9	$IMDiagServerRun 0
    10	$IMDiagAbortTimeout 580
    11	
    12	:syslogtag, contains, "rsyslogd"  ./rstb_309614_999fa94f2.started
    13	###### end of testbench instrumentation part, test conf follows:
    14	
    15	module(	load="../plugins/omrelp/.libs/omrelp" 
    16		tls.tlslib="openssl")
    17	
    18	action(	type="omrelp" target="127.0.0.1" port="35529" tls="on"
    19		tls.tlscfgcmd="Protocol=-ALL,TLSv1.2" )
rsyslogd: NOTE: RSYSLOG_DEBUG_TIMEOUTS_TO_STDERR activated
rsyslogd 8.2001.0 error: invalid debug option 'nologfuncflow' - ignored
rsyslogd 8.2001.0 error: invalid debug option 'noprintmutexaction' - ignored
main Q:Reg: worker start requested, num workers currently 0
main Q:Reg: wrkr start initiated with state 0, num workers now 1
rsyslog debug: main Q:Reg: worker 0x7f7ba6843a40 started
rsyslog debug: main Q:Reg: started with state 3, num workers now 1
09:46:58[1]  rstb_309614_999fa94f:2.pid found, pid 39976
09:46:58[1]  rsyslogd2 startup msg seen, pid  39976
waiting for file rstb_309614_999fa94f.imdiag2.port
imdiag2 port: 366132
injecting 1000 messages
imdiag[40475]: 1000 messages injected
Shutting down instance 2
imdiag: wait q_empty: qsize 935 nempty 0
imdiag: wait q_empty: qsize 935 nempty 0
imdiag: wait q_empty: qsize 780 nempty 0
imdiag: wait q_empty: qsize 524 nempty 0
imdiag: wait q_empty: qsize 268 nempty 0
imdiag: wait q_empty: qsize 268 nempty 0
imdiag: wait q_empty: qsize 0 nempty 1
imdiag: wait q_empty: qsize 0 nempty 2
imdiag: wait q_empty: qsize 0 nempty 3
imdiag: wait q_empty: qsize 0 nempty 4
imdiag: wait q_empty: qsize 0 nempty 5
imdiag: wait q_empty: qsize 0 nempty 6
imdiag[40475]: mainqueue empty
DoDie called.
rsyslogd debug: info: trying to cooperatively stop input ../plugins/imdiag/.libs/imdiag, timeout 60000 ms
rsyslog debug: main Q:Reg/w0: enter WrkrExecCleanup
rsyslog debug: 0x7f7ba68a5840: worker exiting
rsyslog debug: main Q:Reg/w0: thread joined
09:47:00[3]  wait on shutdown of 39976
Shutting down instance 1
imdiag: wait q_empty: qsize 0 nempty 1
imdiag: wait q_empty: qsize 0 nempty 2
imdiag: wait q_empty: qsize 0 nempty 3
imdiag: wait q_empty: qsize 0 nempty 4
imdiag: wait q_empty: qsize 0 nempty 5
imdiag: wait q_empty: qsize 0 nempty 6
imdiag[36613]: mainqueue empty
DoDie called.
rsyslogd debug: info: trying to cooperatively stop input ../plugins/imdiag/.libs/imdiag, timeout 60000 ms
rsyslogd debug: info: trying to cooperatively stop input imrelp, timeout 60000 ms
rsyslog debug: main Q:Reg/w0: enter WrkrExecCleanup
rsyslog debug: 0x7ff1c7ca58e0: worker exiting
rsyslog debug: main Q:Reg/w0: thread joined
09:47:01[4]  wait on shutdown of 39945
content_check did not yet succeed
content_check did not yet succeed
@Whissi
Copy link
Contributor Author

Whissi commented Jan 18, 2020

@alorbach
Copy link
Member

Can you make sure that librelp 1.5 is really in place and installed?
Did you build rsyslog yourself or installed it from our repositories?

@alorbach alorbach self-assigned this Feb 18, 2020
@Whissi
Copy link
Contributor Author

Whissi commented Mar 5, 2020

Still failing with rsyslog-8.2002.0.
This is Gentoo Linux, everything is built from source. Yes, librelp-1.5.0 is used.

build.txt

@alorbach
Copy link
Member

alorbach commented Mar 5, 2020

Your librelp was build without OpenSSL support, you can see the gnutls calls in the debug log. And the test is specially testing OpenSSL tls config commands, thats why it is failing.

@rgerhards
Copy link
Member

mhhh... I think we need to change the test to skip in this case. Not sure if there is already plumbing for this.

@Whissi
Copy link
Contributor Author

Whissi commented Apr 28, 2020

Thanks, you are right. Tests are passing when librelp is using OpenSSL (tested with latest librelp-1.6.0 and rsyslog-8.2004.0).
Is this just a test which is testing OpenSSL-specific things or is there also real runtime risk when you are mixing used SSL libraries between rsyslog and librelp?

@rgerhards
Copy link
Member

@Whissi I don't see any specific risk. If so, I'd tend to say it's a bug.

@alorbach can you pls look into this issue when possible and provide answers?

@alorbach
Copy link
Member

As this test is openssl specific, it's not a bug. The test should not run if librelp was build without openssl support.

@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

1 similar comment
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants