Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testbench: fix empty-hostname.sh test & change support for empty host… #1271

Merged
merged 1 commit into from
Nov 24, 2016

Conversation

rgerhards
Copy link
Member

@rgerhards rgerhards commented Nov 21, 2016

…name

If gethostname() returned "", we used "localhost" as mock-up hostname.
However, this caused problems depending on how the local system name was
actually configured.

We have changed the mock.up hostname to "localhost-empty-hostname" now
to clearly indicate the problem. Not only as a side effect, this also
fixes obtaining a different hostname.

closes #1268

…name

If gethostname() returned "", we used "localhost" as mock-up hostname.
However, this caused problems depending on how the local system name was
actually configured.

We have changed the mock-up hostname to "localhost-empty-hostname" now
to clearly indicate the problem. Also, we make sure that we do no
accidently try to resolve the mock-up hostname.

closes rsyslog#1268
@rgerhards rgerhards added this to the v8.24 milestone Nov 21, 2016
@rgerhards rgerhards self-assigned this Nov 21, 2016
@rgerhards rgerhards merged commit cabb0eb into rsyslog:master Nov 24, 2016
@rgerhards rgerhards deleted the i-1268 branch November 24, 2016 09:54
@rgerhards rgerhards mentioned this pull request Nov 24, 2016
@lock
Copy link

lock bot commented Dec 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/empty-hostname.sh fails: expected hostname "localhost" not found in logs
1 participant