fix issues with atomic operations #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... which also resulted in problems with atomic instruction code not being detected.
commit 87c8f47 fixed missing mutex definition, but did not do so via the macros originally intended for this purpose. It still was very useful, as the patch made omkafka compile on systems without atomic operations. And did so without causing any real overhead. Nevertheless this commit now adjust to use the rsyslog-core intended way of doing things.
can be considered cosmetic, but we really want a clean compile
|
@janmejay If you have second, I would appreciate if you could check the failed Travis build. An obvious cure is to cast away the sign difference, but I have not yet checked if that is problematic. If you do not have time, I'll do that later on. But if you know, that would be much appreciated. |
…ting dynstats usage to it
|
@rgerhards fixed here: rgerhards#40 ( over #2604 ) |
Create support for unsigned 32-bit atomic arithmetic
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... on platforms that do not support them natively. None of them actually break building except when warning-free compile is enforced.
closes #2612