Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lgtm.yml for LGTM.com analysis (with more recent libfastjson-dev) #2778

Merged
merged 5 commits into from Jun 14, 2018

Conversation

sj
Copy link
Contributor

@sj sj commented Jun 14, 2018

LGTM.com recently upgraded the worker infrastructure to Ubuntu 18.04, which contains a newer version of libfastjson-dev. This PR is to check whether the build succeeds with some more plugins enabled.

@rgerhards
Copy link
Member

while you are at it ... can you also do -enable-openssl, which I admit I forgot when merging openssl support ;-) If you are already done, I'll do in a separate PR. Just trying to avoid clutter.

@sj
Copy link
Contributor Author

sj commented Jun 14, 2018

@rgerhards: LGTM.com analysis now succeeds including the --enable-relp --enable-mmnormalize --enable-pmnormalize --enable-openssl --enable-mmgrok --enable-omtcl options to configure. The checks are still waiting for the Travis integration, but that shouldn't be affected by this PR — I'm only changing lgtm.yml.

I think I'm done here — feel free to merge if you're happy with it 🙂

@rgerhards rgerhards merged commit 6442c85 into rsyslog:master Jun 14, 2018
@rgerhards
Copy link
Member

Thx for taking care of this - I am glad to see the additional modules being covered :-)

@rgerhards rgerhards added this to the v8.36 milestone Jun 14, 2018
@lock
Copy link

lock bot commented Dec 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants