testbench: changed tlscommands for librelp tls tests. #4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlscommands for the following tests have been changed: - imrelp-tls-cfgcmd.sh - sndrcv_relp_tls-cfgcmd.sh closes: rsyslog#4534
mbiebl
reviewed
Feb 17, 2021
| @@ -55,7 +63,7 @@ if [ $ret == 0 ]; then | |||
| skip_test | |||
| else | |||
| # Kindly check for a failed session | |||
| content_check "librelp error 10031" $RSYSLOG_DEBUGLOG | |||
| content_check "librelp: generic error: ecode 10031" $RSYSLOG_DEBUGLOG | |||
There was a problem hiding this comment.
its part of the debug output:
https://github.com/rsyslog/librelp/blob/91aef5c53b92f93e47a36beee9c5937c0ec8365b/src/relp.c#L65
|
A better explanation for folks who come across this PR: test bugfix: some tests did not work with newer TLS library versions Newer versions provide TLS versions that cannot be disabled in older versions as they are unkonwn there. This is solved by setting restrictions in multiple steps. For older library versions, the final step will error out, but the other one be applied. This permits to achieve proper test results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tlscommands for the following tests have been changed:
This will make sure the librelp tlscommand tests run well on all librelp versions and with all OpenSSL Version.
Newer OpenSSL Versions would run TLSv1.3 on those tests which is valid for the old tlscommand. However we can NOT disable TLSv1.3 with one tlscommand as this would break the tlsconfcmd for older OpenSSL Versions.
closes: #4534