Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logic from CLI commands to separate classes #38

Closed
5 tasks done
rszamszur opened this issue Feb 8, 2022 · 1 comment · Fixed by #40
Closed
5 tasks done

Refactor logic from CLI commands to separate classes #38

rszamszur opened this issue Feb 8, 2022 · 1 comment · Fixed by #40
Assignees
@rszamszur
Labels
refactor Related to major code refactoring/reorganisation
Milestone
0.8.0

Comments

@rszamszur
Copy link
Member

rszamszur commented Feb 8, 2022 •
edited

  • I have searched the issues of this repo and believe that this is not a duplicate.

Feature Request

Refactor logic from CLI 'new' and 'run' commands to separate classes. It's a bad practice for interfaces to contain execution logic. Moreover, it'll be easier to develop, test, and maintain code that way.

TODO:

  • Decide on design pattern
  • Implement classes
  • Refactor CLI commands
  • Refactor and extend unit tests
@rszamszur rszamszur added enhancement New feature or request refactor Related to major code refactoring/reorganisation and removed enhancement New feature or request labels Feb 8, 2022
@rszamszur rszamszur self-assigned this Feb 8, 2022
@rszamszur rszamszur added this to the 0.8.0 milestone Feb 8, 2022
@rszamszur rszamszur mentioned this issue Feb 8, 2022
Merged
4 tasks
@rszamszur rszamszur linked a pull request Feb 8, 2022 that will close this issue
Refactor logic from CLI to separate clases, Fix #37 #40
Merged
4 tasks
rszamszur added a commit that referenced this issue Feb 8, 2022
@rszamszur
Fix #38
11f20dc
@rszamszur rszamszur mentioned this issue Feb 8, 2022
Merged
4 tasks
@rszamszur
Copy link
Member Author

Ignore above PR #42. I've provided the wrong issue number.

@rszamszur rszamszur mentioned this issue Feb 13, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rszamszur rszamszur

Labels
refactor Related to major code refactoring/reorganisation
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Refactor logic from CLI to separate clases, Fix #37 fastapi-mvc/fastapi-mvc
1 participant
@rszamszur