Flat bundles #705

Andarist · 2018-02-04T23:36:02Z

This is not done, you can track progress & discuss what is being done though.

Andarist · 2018-02-04T23:39:34Z

integration/react/package.json

@@ -1,7 +1,7 @@
 {


as flat bundling will be a breaking change (no more reaching out to internal directory structure - which is even proposed in the main READMEs on several occasions) I'd go with simple redux-persist/react proxy module, I've attempted to keep both redux-persist/integration/react and redux-persist/react here but there is really no point in that

I agree, redux-persist/react is probably best. No issues with breaking changes, although I do have a couple of breaking changes in mind, so we can stack these together for a v6

Andarist · 2018-02-04T23:40:50Z

package.json

@@ -2,22 +2,24 @@
  "name": "redux-persist",
  "version": "5.6.9",
  "description": "persist and rehydrate redux stores",
-  "main": "lib/index.js",
-  "module": "es/index.js",
+  "main": "dist/redux-persist",


this is matching first draft of the configs - the ones that are commented out now

Andarist · 2018-02-04T23:43:55Z

package.json

-    "build": "npm run flow-copy && npm run build:commonjs && npm run build:es && npm run build:umd && npm run build:umd:min",
+    "prebuild": "npm run clean",
+    "build": "rollup -c",
+    "build:old": "npm run flow-copy && npm run build:commonjs && npm run build:es && npm run build:umd && npm run build:umd:min",


im not entirely sure what's proper way of supporting typings after going flat, "typings" from flow-copy will stop to work properly, I'd like to explore gen-flow-files tool (its flow builtin, but ive never used it)

TS will require some work, but at least its a sideway thing (have to be written manually anyway - so it doesnt really matter that much, im concerned about flow because I'd like to generate them automatically and aint sure yet how to do it in a new setup)

I am not sure either. gen-flow-files may work, last I tried it was buggy but that was maybe a year ago.

Figuring this out will be a big concern however, having types is important and maintaining separate flow types is not desirable obviously (maintaining .ts declarations is already a big burden).

Is it possible to bundle w/o stripping flow types? then we could basically ship a mirrored redux-persist.flow.js bundle, which is basically all flow-copy-source does anyway.

unfortunately aint sure, need to play with those things first

Andarist · 2018-02-04T23:44:45Z

rollup.config.js

-    exports: 'named',
-    sourcemap: true,  
-  },
+// const ensureArray = maybeArr => Array.isArray(maybeArr) ? maybeArr : [maybeArr];


this part is very much working, although not yet supporting storage and .native.js (they can be easily added, I just havent yet got to it)

Andarist · 2018-02-04T23:48:29Z

rollup.config.js

+  umd = false,
+  env,
+} = {}) => ({
+  experimentalCodeSplitting: !umd,


this version is interesting though, because it uses code splitting feature - this way babel helpers can be deduped between redux-persist, redux-persist/storage and redux-persist/react flat bundles. I've found a bug in rollup while experimenting with this though - rollup/rollup#1943

It would also require restructuring redux-persist src directory structure slightly, because rollup maps original input filenames to output names (not including directories) and we need stable mapping between those

cant say I understand. So how would src be restructured?

How would babel helpers get deduped?

At the moment with this:

input: ['src/index.js', 'src/integration/react.js', 'src/storage/index.js']

It produces 4 files:

index.js (what will be in main/module)

index2.js (this should actually be storage for readability, that's why we need to restructure a little bit, so input file names get unique names)

react.js

chunk1.js - here we have magically deduped babel helpers :)

Andarist · 2018-02-04T23:49:00Z

src/index.js

@@ -9,4 +9,8 @@ export { default as getStoredState } from './getStoredState'
 export { default as createPersistoid } from './createPersistoid'
 export { default as purgeStoredState } from './purgeStoredState'

+export { default as autoMergeLevel1 } from './stateReconciler/autoMergeLevel1'


from what I understand it's what we have established in the other issue, correct me if im wrong

👍 I think so, but definitely want to get other opinions here. Are there any cases where we cannot rely on code splitting? Will this negatively impact any use cases?

dont think so, I consider this new setup with code-splitting the most "optimized"

Andarist · 2018-02-04T23:49:09Z

src/integration/react.js

@@ -1,5 +1,5 @@
 // @flow
-import React, { PureComponent } from 'react' // eslint-disable-line import/no-unresolved


Andarist · 2018-02-04T23:50:18Z

src/storage/index.js

@@ -3,3 +3,4 @@
 import createWebStorage from './createWebStorage'

 export default createWebStorage('local')
+export { default as session } from './session'


I plan to add #__PURE__ annotations with my plugin - https://github.com/Andarist/babel-plugin-annotate-pure-calls . So unused version should get dropped. The goal for me here was to provide a single redux-persist/storage entry

Andarist · 2018-02-15T11:11:02Z

rollup has released new version with the needed bug fix. Gonna play with this PR further in following days, @rt2zz do you have any comments about what was being done so far (or about what was proposed in the comments)?

rt2zz · 2018-02-16T07:30:38Z

package.json

  "types": "./src/index.d.ts",
  "repository": "rt2zz/redux-persist",
  "files": [
    "es",
    "src",
-    "lib"
+    "lib",


lib and es will go away with this correct?

actually not, i thought at first they would, but with code splitting on we do not have control over output file names so we need to output files targeting cjs and esm into 2 separate directories to avoid the file path clash

rt2zz · 2018-02-16T07:47:47Z

responded.

I think the only two considerations I have moving forward are:

How does this look if we want to provide a umd build? The umd bundle will have a few extra bytes from the state reconcilers which I think is acceptable. Are there any other concerns?
How do we get flow types to work? I am pretty sure this can be done by doing a build without transform-flow-strip-types, and writing that to redux-persist.flow.js.
because of the breaking changes, will definitely want to land this along-side other breaking changes that I am mulling over around how we store _persist, and async transforms.

Andarist · 2018-02-17T20:04:46Z

How does this look if we want to provide a umd build? The umd bundle will have a few extra bytes from the state reconcilers which I think is acceptable. Are there any other concerns?

It depends what it needs to have, i suppose no react & storage in there? Or should storage be available in umd?

How do we get flow types to work? I am pretty sure this can be done by doing a build without transform-flow-strip-types, and writing that to redux-persist.flow.js.

That's the only thing I need to experiment with - ain't sure if rollup won't chuck when parsing type nodes.

because of the breaking changes, will definitely want to land this along-side other breaking changes that I am mulling over around how we store _persist, and async transforms.

definitely, this is a breaking change

Andarist · 2018-02-18T00:36:25Z

package.json

    "integration",
-    "README.md"
+    "dist"


README gets uploaded to npm by default

Andarist · 2018-02-18T00:54:03Z

Ok, I got everything to work. Just one thing is not updated - typescript typings and unfortunately I won't be able to update them right now. Updating them shouldn't take much time though.

This is imho ready for final review and ready to be merged. If you have any questions regarding what I've done - just ask :)

Andarist commented Feb 4, 2018

View reviewed changes

Andarist force-pushed the flat-bundles branch from 43542b9 to 76fe058 Compare February 15, 2018 11:07

rt2zz reviewed Feb 16, 2018

View reviewed changes

Andarist force-pushed the flat-bundles branch from 76fe058 to 6ed304d Compare February 18, 2018 00:33

Andarist commented Feb 18, 2018

View reviewed changes

package.json

"integration",

"README.md"

"dist"

Copy link

Collaborator Author

Andarist Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README gets uploaded to npm by default

Andarist force-pushed the flat-bundles branch from 6ed304d to 871c61f Compare February 18, 2018 00:50

Flat bundles

4edc048

Andarist force-pushed the flat-bundles branch from 871c61f to 4edc048 Compare February 18, 2018 00:51

Andarist changed the title ~~[WIP] Flat bundles~~ Flat bundles Feb 18, 2018

Andarist mentioned this pull request Feb 23, 2018

Treat imported subdirectories/files from packages as external too developit/microbundle#83

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flat bundles #705

Flat bundles #705

Andarist commented Feb 4, 2018

Andarist Feb 4, 2018

rt2zz Feb 16, 2018

Andarist Feb 4, 2018

Andarist Feb 4, 2018 •

edited

Loading

rt2zz Feb 16, 2018

Andarist Feb 17, 2018

Andarist Feb 4, 2018

Andarist Feb 4, 2018

rt2zz Feb 16, 2018

Andarist Feb 17, 2018

Andarist Feb 4, 2018

rt2zz Feb 16, 2018

Andarist Feb 17, 2018

Andarist Feb 4, 2018

Andarist Feb 4, 2018

Andarist commented Feb 15, 2018

rt2zz Feb 16, 2018

Andarist Feb 17, 2018

rt2zz commented Feb 16, 2018

Andarist commented Feb 17, 2018

Andarist Feb 18, 2018

Andarist commented Feb 18, 2018

		@@ -1,5 +1,5 @@
		// @flow
		import React, { PureComponent } from 'react' // eslint-disable-line import/no-unresolved

Flat bundles #705

Are you sure you want to change the base?

Flat bundles #705

Conversation

Andarist commented Feb 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Andarist Feb 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Andarist commented Feb 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rt2zz commented Feb 16, 2018

Andarist commented Feb 17, 2018

Choose a reason for hiding this comment

Andarist commented Feb 18, 2018

Andarist Feb 4, 2018 •

edited

Loading