Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid importing the whole lodash #81

Merged
merged 1 commit into from Apr 30, 2016
Merged

Conversation

ratson
Copy link
Contributor

@ratson ratson commented Apr 29, 2016

No description provided.

@rt2zz
Copy link
Owner

rt2zz commented Apr 29, 2016

Do you know why redux does not use babel-lodash? I based my implementation on that.

@ratson
Copy link
Contributor Author

ratson commented Apr 30, 2016

Because the author avoided import _ from 'lodash, by importing used functions directly, e.g. import isPlainObject from 'lodash/isPlainObject', see https://github.com/reactjs/redux/blob/master/src/createStore.js

@rt2zz
Copy link
Owner

rt2zz commented Apr 30, 2016

👍

@rt2zz rt2zz merged commit 6b1bd79 into rt2zz:master Apr 30, 2016
@jorilallo
Copy link

Thanks for making the change, it has a pretty significant effect on the bundle size. Would be nice to get a release as lib isn't part of the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants