Fixes #16 Unit test cases for plugin #19

surajkrsingh · 2019-04-25T13:59:27Z

Fixes #16

rtBot

phpcs scanning turned up:

❗ 2 warnings

hashes-api-scanning skipped

tests/bootstrap.php

rtBot

phpcs scanning turned up:

🚫 2 errors

hashes-api-scanning skipped

tests/test-class-plugin.php

…re/issue-16

rtBot

phpcs scanning turned up:

❗ 7 warnings

hashes-api-scanning skipped

tests/test-class-google-auth.php

tests/class-utility.php

tests/bootstrap.php

…re/issue-16

rtBot

phpcs scanning turned up:

❗ 2 warnings

hashes-api-scanning skipped

tests/test-class-google-auth.php

rtBot

phpcs scanning turned up:

🚫 1 error

❗ 2 warnings

hashes-api-scanning skipped

tests/test-class-google-auth.php

Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>

rtBot

phpcs scanning turned up:

🚫 21 errors

⚠️ 10 warnings

hashes-api-scanning skipped

Posting will continue in further review(s)

rtBot · 2020-01-16T15:19:19Z

tests/test-class-plugin.php

+
+	}
+
+	/**


🚫 Error: Missing short description in doc comment (Generic.Commenting.DocComment.MissingShort).

rtBot · 2020-01-16T15:19:19Z

tests/test-class-plugin.php

+
+	}
+
+	/**


🚫 Error: Missing short description in doc comment (Generic.Commenting.DocComment.MissingShort).

rtBot · 2020-01-16T15:19:19Z

tests/test-class-plugin.php

+		parent::setUp();
+	}
+
+	/**


🚫 Error: Missing short description in doc comment (Generic.Commenting.DocComment.MissingShort).

rtBot · 2020-01-16T15:19:19Z

tests/test-class-plugin.php

+ */
+class Test_Plugin extends \WP_UnitTestCase {
+
+	/**


🚫 Error: Missing short description in doc comment (Generic.Commenting.DocComment.MissingShort).

rtBot · 2020-01-16T15:19:20Z

tests/test-class-helper.php

+		$this->assertEquals( $_ENV['custom_key'], Helper::filter_input( INPUT_ENV, 'custom_key' ) );
+		$this->assertEquals( $_SERVER['HTTP_HOST'], Helper::filter_input( INPUT_SERVER, 'HTTP_HOST' ) );
+
+		unset( $_GET['custom_key'], $_POST['custom_key'], $_COOKIE['custom_key'], $_ENV['custom_key'] );


⚠️ Warning: Due to using Batcache, server side based client related logic will not work, use JS instead (WordPressVIPMinimum.Variables.RestrictedVariables.cache_constraints___COOKIE).

rtBot · 2020-01-16T15:19:20Z

tests/test-class-helper.php

+		$this->assertEquals( $_ENV['custom_key'], Helper::filter_input( INPUT_ENV, 'custom_key' ) );
+		$this->assertEquals( $_SERVER['HTTP_HOST'], Helper::filter_input( INPUT_SERVER, 'HTTP_HOST' ) );
+
+		unset( $_GET['custom_key'], $_POST['custom_key'], $_COOKIE['custom_key'], $_ENV['custom_key'] );


⚠️ Warning: Processing form data without nonce verification (WordPress.Security.NonceVerification.Recommended).

rtBot · 2020-01-16T15:19:20Z

tests/test-class-helper.php

+		$this->assertEquals( $_POST['custom_key'], Helper::filter_input( INPUT_POST, 'custom_key' ) );
+		$this->assertEquals( $_COOKIE['custom_key'], Helper::filter_input( INPUT_COOKIE, 'custom_key' ) );
+		$this->assertEquals( $_ENV['custom_key'], Helper::filter_input( INPUT_ENV, 'custom_key' ) );
+		$this->assertEquals( $_SERVER['HTTP_HOST'], Helper::filter_input( INPUT_SERVER, 'HTTP_HOST' ) );


🚫 Error: Detected usage of a non-sanitized input variable: $_SERVER['HTTP_HOST'] (WordPress.Security.ValidatedSanitizedInput.InputNotSanitized).

rtBot · 2020-01-16T15:19:20Z

tests/test-class-helper.php

+		$this->assertEquals( $_POST['custom_key'], Helper::filter_input( INPUT_POST, 'custom_key' ) );
+		$this->assertEquals( $_COOKIE['custom_key'], Helper::filter_input( INPUT_COOKIE, 'custom_key' ) );
+		$this->assertEquals( $_ENV['custom_key'], Helper::filter_input( INPUT_ENV, 'custom_key' ) );
+		$this->assertEquals( $_SERVER['HTTP_HOST'], Helper::filter_input( INPUT_SERVER, 'HTTP_HOST' ) );


🚫 Error: Detected usage of a possibly undefined superglobal array index: $_SERVER['HTTP_HOST']. Use isset() or empty() to check the index exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated).

rtBot · 2020-01-16T15:19:21Z

tests/test-class-helper.php

+
+		$this->assertEquals( $_GET['custom_key'], Helper::filter_input( INPUT_GET, 'custom_key' ) );
+		$this->assertEquals( $_POST['custom_key'], Helper::filter_input( INPUT_POST, 'custom_key' ) );
+		$this->assertEquals( $_COOKIE['custom_key'], Helper::filter_input( INPUT_COOKIE, 'custom_key' ) );


🚫 Error: Detected usage of a non-sanitized input variable: $_COOKIE['custom_key'] (WordPress.Security.ValidatedSanitizedInput.InputNotSanitized).

rtBot · 2020-01-16T15:19:21Z

tests/test-class-helper.php

+
+		$this->assertEquals( $_GET['custom_key'], Helper::filter_input( INPUT_GET, 'custom_key' ) );
+		$this->assertEquals( $_POST['custom_key'], Helper::filter_input( INPUT_POST, 'custom_key' ) );
+		$this->assertEquals( $_COOKIE['custom_key'], Helper::filter_input( INPUT_COOKIE, 'custom_key' ) );


🚫 Error: Detected usage of a possibly undefined superglobal array index: $_COOKIE['custom_key']. Use isset() or empty() to check the index exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated).

rtBot

Previous scan continued.

rtBot · 2020-01-16T15:19:23Z

tests/test-class-helper.php

+
+		$this->assertEquals( $_GET['custom_key'], Helper::filter_input( INPUT_GET, 'custom_key' ) );
+		$this->assertEquals( $_POST['custom_key'], Helper::filter_input( INPUT_POST, 'custom_key' ) );
+		$this->assertEquals( $_COOKIE['custom_key'], Helper::filter_input( INPUT_COOKIE, 'custom_key' ) );


⚠️ Warning: Due to using Batcache, server side based client related logic will not work, use JS instead (WordPressVIPMinimum.Variables.RestrictedVariables.cache_constraints___COOKIE).

rtBot · 2020-01-16T15:19:24Z

tests/test-class-helper.php

+		$_ENV['custom_key']    = 'Values on ENV variable.';
+
+		$this->assertEquals( $_GET['custom_key'], Helper::filter_input( INPUT_GET, 'custom_key' ) );
+		$this->assertEquals( $_POST['custom_key'], Helper::filter_input( INPUT_POST, 'custom_key' ) );


🚫 Error: Detected usage of a non-sanitized input variable: $_POST['custom_key'] (WordPress.Security.ValidatedSanitizedInput.InputNotSanitized).

rtBot · 2020-01-16T15:19:24Z

tests/test-class-helper.php

+		$_ENV['custom_key']    = 'Values on ENV variable.';
+
+		$this->assertEquals( $_GET['custom_key'], Helper::filter_input( INPUT_GET, 'custom_key' ) );
+		$this->assertEquals( $_POST['custom_key'], Helper::filter_input( INPUT_POST, 'custom_key' ) );


🚫 Error: Detected usage of a possibly undefined superglobal array index: $_POST['custom_key']. Use isset() or empty() to check the index exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated).

rtBot · 2020-01-16T15:19:24Z

tests/test-class-helper.php

+		$_ENV['custom_key']    = 'Values on ENV variable.';
+
+		$this->assertEquals( $_GET['custom_key'], Helper::filter_input( INPUT_GET, 'custom_key' ) );
+		$this->assertEquals( $_POST['custom_key'], Helper::filter_input( INPUT_POST, 'custom_key' ) );


🚫 Error: Processing form data without nonce verification (WordPress.Security.NonceVerification.Missing).

rtBot · 2020-01-16T15:19:24Z

tests/test-class-helper.php

+		$_COOKIE['custom_key'] = 'Values on COOKIE variable.';
+		$_ENV['custom_key']    = 'Values on ENV variable.';
+
+		$this->assertEquals( $_GET['custom_key'], Helper::filter_input( INPUT_GET, 'custom_key' ) );


🚫 Error: Detected usage of a non-sanitized input variable: $_GET['custom_key'] (WordPress.Security.ValidatedSanitizedInput.InputNotSanitized).

rtBot · 2020-01-16T15:19:24Z

tests/test-class-helper.php

+		$_COOKIE['custom_key'] = 'Values on COOKIE variable.';
+		$_ENV['custom_key']    = 'Values on ENV variable.';
+
+		$this->assertEquals( $_GET['custom_key'], Helper::filter_input( INPUT_GET, 'custom_key' ) );


🚫 Error: Detected usage of a possibly undefined superglobal array index: $_GET['custom_key']. Use isset() or empty() to check the index exists before using it (WordPress.Security.ValidatedSanitizedInput.InputNotValidated).

rtBot · 2020-01-16T15:19:25Z

tests/test-class-helper.php

+		$_COOKIE['custom_key'] = 'Values on COOKIE variable.';
+		$_ENV['custom_key']    = 'Values on ENV variable.';
+
+		$this->assertEquals( $_GET['custom_key'], Helper::filter_input( INPUT_GET, 'custom_key' ) );


⚠️ Warning: Processing form data without nonce verification (WordPress.Security.NonceVerification.Recommended).

rtBot · 2020-01-16T15:19:25Z

tests/test-class-helper.php

+		 */
+		$_GET['custom_key']    = 'Values on GET variable.';
+		$_POST['custom_key']   = 'Values on POST variable.';
+		$_COOKIE['custom_key'] = 'Values on COOKIE variable.';


⚠️ Warning: Due to using Batcache, server side based client related logic will not work, use JS instead (WordPressVIPMinimum.Variables.RestrictedVariables.cache_constraints___COOKIE).

rtBot · 2020-01-16T15:19:25Z

tests/test-class-helper.php

+		$this->assertEquals( '', $output );
+	}
+
+	/**


🚫 Error: Missing short description in doc comment (Generic.Commenting.DocComment.MissingShort).

rtBot · 2020-01-16T15:19:25Z

tests/test-class-helper.php

+ */
+class Test_Helper extends \WP_UnitTestCase {
+
+	/**


🚫 Error: Missing short description in doc comment (Generic.Commenting.DocComment.MissingShort).

rtBot

Previous scan continued.

rtBot · 2020-01-16T15:19:28Z

tests/test-class-google-auth.php

+
+	}
+
+	/**


🚫 Error: Missing short description in doc comment (Generic.Commenting.DocComment.MissingShort).

rtBot · 2020-01-16T15:19:28Z

tests/test-class-google-auth.php

+
+	}
+
+	/**


🚫 Error: Missing short description in doc comment (Generic.Commenting.DocComment.MissingShort).

rtBot · 2020-01-16T15:19:28Z

tests/test-class-google-auth.php

+		if ( empty( $_redirect_to ) ) {
+			$this->assertEquals( $state[0], admin_url() );
+		} else {
+			$this->assertEquals( $state[0], $_redirect_to );


⚠️ Warning: Variable $_redirect_to is undefined (WordPressVIPMinimum.Variables.VariableAnalysis.UndefinedVariable).

rtBot · 2020-01-16T15:19:28Z

tests/test-class-google-auth.php

+		$state = $client_config['state'];
+		$state = explode( '|', urldecode_deep( $state ) );
+
+		if ( empty( $_redirect_to ) ) {


⚠️ Warning: Variable $_redirect_to is undefined (WordPressVIPMinimum.Variables.VariableAnalysis.UndefinedVariable).

rtBot · 2020-01-16T15:19:29Z

tests/bootstrap.php

+tests_add_filter( 'muplugins_loaded', '_manually_load_plugin' );
+
+// Start up the WP testing environment.
+require_once $_tests_dir . '/includes/bootstrap.php';


⚠️ Warning: File inclusion using variable ($_tests_dir). Probably needs manual inspection (WordPressVIPMinimum.Files.IncludingFile.UsingVariable).

rtBot · 2020-01-16T15:19:29Z

tests/bootstrap.php

+}
+
+// Give access to tests_add_filter() function.
+require_once $_tests_dir . '/includes/functions.php';


⚠️ Warning: File inclusion using variable ($_tests_dir). Probably needs manual inspection (WordPressVIPMinimum.Files.IncludingFile.UsingVariable).

tests/bootstrap.php

inc/classes/class-helper.php

rtBot

Previous scan continued.

inc/classes/class-helper.php

Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>

rtBot

phpcs scanning turned up:

⚠️ 1 warning

hashes-api-scanning skipped

tests/bootstrap.php

To re trigger review

rtBot

phpcs scanning turned up:

🚫 5 errors

hashes-api-scanning skipped

tests/test-class-google-auth.php

inc/classes/class-google-auth.php

Changes addressed

rtBot

phpcs scanning turned up:

🚫 1 error

hashes-api-scanning skipped

inc/classes/class-google-auth.php

Fixed issues

surajkrsingh added 3 commits April 25, 2019 18:43

Create hello world test case

84599e9

Fix test function name

1bc8b5f

Fix phpcs

4b1e08c

rtBot reviewed Apr 25, 2019

View reviewed changes

tests/bootstrap.php Outdated Show resolved Hide resolved

tests/bootstrap.php Show resolved Hide resolved

surajkrsingh changed the title ~~Work in progress~~ Fixes #16 WIP Unit test cases for plugin Apr 25, 2019

surajkrsingh added 2 commits April 25, 2019 19:39

Ignore phpcs for bootstrap.php

e199c5f

Add test class for plugin

6b62a5e

rtBot requested changes Apr 26, 2019

View reviewed changes

tests/test-class-plugin.php Outdated Show resolved Hide resolved

tests/test-class-plugin.php Show resolved Hide resolved

surajkrsingh added 4 commits April 26, 2019 11:53

Merge branch 'master' of github.com:rtCamp/wp-google-login into featu…

4afd77a

…re/issue-16

Complete testcase for plugin class

a3b1f6f

Add helper test class

26f4218

Add test class for google-auth

9ad4eb8

rtBot reviewed Apr 29, 2019

View reviewed changes

surajkrsingh added 3 commits April 29, 2019 19:33

Fix undefined variable

0293ea3

Merge branch 'master' of github.com:rtCamp/wp-google-login into featu…

5b212f6

…re/issue-16

Add test cases for google-auth functions

90f0c80

rtBot reviewed May 15, 2019

View reviewed changes

tests/test-class-google-auth.php Outdated Show resolved Hide resolved

tests/test-class-google-auth.php Outdated Show resolved Hide resolved

dhavalparekhrtcamp and others added 2 commits May 15, 2019 19:33

Issue-16, revert changes for issue-20

a8b4145

Write testcase for authenticate_user function

dae9957

rtBot previously requested changes May 20, 2019

View reviewed changes

tests/test-class-google-auth.php Outdated Show resolved Hide resolved

tests/test-class-google-auth.php Outdated Show resolved Hide resolved

tests/test-class-google-auth.php Outdated Show resolved Hide resolved

Issue-16, Update phpunit.xml file, fix broken test cases

6181cc2

PatelUtkarsh assigned dhaval-parekh and unassigned dhaval-parekh Nov 18, 2019

PatelUtkarsh requested a review from dhaval-parekh November 18, 2019 13:57

surajkrsingh added 6 commits December 2, 2019 11:49

Create hello world test case

de994e6

Fix test function name

1ea2c90

Fix phpcs

1c3fd98

Ignore phpcs for bootstrap.php

34900e7

Add test class for plugin

899d72f

Complete testcase for plugin class

5340fbf

This was referenced Jan 14, 2020

Php Unit test case setup rtCamp/amp-admanager#60

Open

Setup and add unit test cases rtCamp/pwa-extension#19

Closed

mrrobot47 added 2 commits January 16, 2020 19:02

Update phpcs action

3a57257

Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>

Add GitHub action to run PHPUnit test in CI

2448fbc

Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>

rtBot requested changes Jan 16, 2020

View reviewed changes

rtBot previously requested changes Jan 16, 2020

View reviewed changes

inc/classes/class-helper.php Outdated Show resolved Hide resolved

Exclude PHPCS checks in tests

d0c3cd0

Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>

rtBot reviewed Jan 16, 2020

View reviewed changes

tests/bootstrap.php Outdated Show resolved Hide resolved

deepaklalwani97 added 2 commits January 16, 2020 22:04

Issue-19: Update phpcs ignore comment

48261b7

Issue-19: fix phpcs

5ba6259

deepaklalwani97 requested a review from rtBot January 16, 2020 16:46

Issue-16: Fix test code coverage

1c1d6bd

rtBot previously requested changes Jan 20, 2020

View reviewed changes

Issue-16: Fix phpcs

bdac29d

deepaklalwani97 added 2 commits January 20, 2020 12:37

Issue-16: Remove full stop from codecoverageignore

e53e5af

Issue-16: Add comment for code coverage ignore

45a6b18

rtBot previously requested changes Jan 20, 2020

View reviewed changes

inc/classes/class-google-auth.php Outdated Show resolved Hide resolved

Issue-16: Fix phpcs

5770313

deepaklalwani97 added 2 commits January 20, 2020 14:00

Issue-19: Add mising covers annotation

ee6a207

Issue-16: Add unit test setup details to readme

d18b8ca

DevikVekariya mentioned this pull request Jan 22, 2020

Php Unit test case setup rtCamp/blank-theme#33

Open

deepaklalwani97 changed the base branch from master to develop January 29, 2020 10:10

deepaklalwani97 merged commit 9eeb5e6 into develop Jan 29, 2020

deepaklalwani97 mentioned this pull request Jan 29, 2020

Add unit-test #16

Closed

2 tasks

rahul286 deleted the feature/issue-16 branch February 23, 2022 11:15

Fixes #16 Unit test cases for plugin #19

Fixes #16 Unit test cases for plugin #19

Conversation

surajkrsingh commented Apr 25, 2019 • edited by PatelUtkarsh Loading

rtBot left a comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

rtBot left a comment

Choose a reason for hiding this comment

surajkrsingh commented Apr 25, 2019 •

edited by PatelUtkarsh

Loading