Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo causing failure to purge on trashed comment. #159

Merged
merged 1 commit into from Nov 15, 2018
Merged

Fix typo causing failure to purge on trashed comment. #159

merged 1 commit into from Nov 15, 2018

Conversation

@jinschoi
Copy link
Contributor

@jinschoi jinschoi commented Oct 28, 2018

Deleting a comment administratively wasn't triggering a purge. Cause is a status typo, $oldstatus == 'approve' should be 'approved'.

rahulsprajapati added a commit to rahulsprajapati/nginx-helper that referenced this issue Nov 15, 2018
@rahulsprajapati
Copy link
Contributor

@rahulsprajapati rahulsprajapati commented Nov 15, 2018

Confirmed the issue, and fix is working fine.
Thank you for the PR @jinschoi.

We've refactored this plugin for v2.0.0 and will be releasing soon, added fix in that also ref: a40a126

@rahulsprajapati rahulsprajapati merged commit 5847ac6 into rtCamp:master Nov 15, 2018
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants