Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugged locations that were sending purge requests even if disabled #168

Merged
merged 1 commit into from Dec 19, 2019

Conversation

@jaredwsmith
Copy link
Contributor

jaredwsmith commented Jan 9, 2019

There are a few locations in nginx-helper (dating back to at least 1.9.10) that were sending requests to /purge/ even if cache purging was disabled in settings. On our environment, this was causing errors and unnecessary load on our infrastructure. My patch simply adds guard conditions to Purger::purge_image_on_edit, Purger::purge_on_taxonomy_term_edited, and Purger::purge_on_check_ajax_referer.

@chandrapatel

This comment has been minimized.

Copy link
Collaborator

chandrapatel commented Dec 19, 2019

Hi @jaredwsmith Thanks for the PR. I have approved PR and merging PR.

@chandrapatel chandrapatel merged commit f81737f into rtCamp:master Dec 19, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
WIP Ready for review
Details
@thrijith thrijith mentioned this pull request Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.